search

Grinnz / Mojo-SQLite

Mojo::SQLite - A tiny Mojolicious wrapper for SQLite
https://metacpan.org/pod/Mojo::SQLite
Other
27 stars 12 forks source link

use Mojo::Promise instead of deprecated Mojo::IOLoop::Delay #20

Closed s1037989 closed 3 years ago

s1037989 commented 3 years ago

Mojolicious 9.0 removed the delay method from Mojo::IOLoop.

Grinnz commented 3 years ago

Thanks for this. It also addresses #14. One problem is that these methods, like ->query with a callback, are not non-blocking because sqlite access cannot be. Their docs should say something similar to this part of the query docs: "for API compatibility with Mojo::Pg; the query is still executed in a blocking manner."

s1037989 commented 3 years ago

Thanks for the reminder! I updated the PR.