Grishberg / android-youtube-player

Automatically exported from code.google.com/p/android-youtube-player
0 stars 0 forks source link

Android 4.3 UP + Fullscreen Video View #28

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Nexus 5 or Genymod with Android 4.3

What is the expected output? What do you see instead?
Controls are smaller and fullscreen, but video is small.

What version of the product are you using? On what operating system?
4.3

Please provide any additional information below.
Could you sell me the source so i could fix it or would you 
make that ? I can even donate

Original issue reported on code.google.com by elec...@gmail.com on 15 Jan 2014 at 5:56

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed full screen issue. Check attached 1.4 jar file.

Remember to add

   <activity android:name="com.keyes.youtube.OpenYouTubePlayerActivity"
            android:configChanges="orientation"></activity>

Original comment by gasforr...@gmail.com on 18 Feb 2014 at 9:58

Attachments:

GoogleCodeExporter commented 9 years ago
Is there a patch to the source code to apply? We are not using jar file, can 
this be fixed on the code branch?

Original comment by anilredd...@gmail.com on 28 Apr 2014 at 4:12

GoogleCodeExporter commented 9 years ago
Why don't you upload the latest jar to the download page. The jar file on the 
download page is still 1.1.

Original comment by horikawa...@gmail.com on 10 Jun 2014 at 8:47

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
I have similar question as anilredd... for some reason my app stops playbacking 
videos with 1.4. I was using source before to compile my jar, now nothing 
happens and logs are blank. Would be nice to see what's going on.

Original comment by jekabs.k...@gmail.com on 1 Aug 2014 at 2:18

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Hope this helps you guys:

Issue is a change in Android 4.3 and the handling of calculation of the layout. 

>>> EXPLANATION:
If your app uses VideoView... 
(https://developer.android.com/about/versions/android-4.3.html)

Your video might appear smaller on Android 4.3.
On previous versions of Android, the VideoView widget incorrectly calculated 
the "wrap_content" value for layout_height and layout_width to be the same as 
"match_parent". So while using "wrap_content" for the height or width may have 
previously provided your desired video layout, doing so may result in a much 
smaller video on Android 4.3 and higher. To fix the issue, replace 
"wrap_content" with "match_parent" and verify your video appears as expected on 
Android 4.3 as well as on older versions.

>>> FIX:
Go to the OpenYouTubeActivityPlayer.java Class and replace  WRAP_CONTENT -> 
MATCH_PARENT in the following lines:

android.widget.RelativeLayout.LayoutParams lRelLayoutParms = new 
android.widget.RelativeLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, 
ViewGroup.LayoutParams.MATCH_PARENT);
android.widget.RelativeLayout.LayoutParams lVidViewLayoutParams = new 
android.widget.RelativeLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, 
ViewGroup.LayoutParams.MATCH_PARENT);

That should be around line number 300.

Original comment by alex.wil...@gmail.com on 12 Oct 2014 at 8:20