Jars with plugin metadata

GritsToolbox / org.grits.toolbox

GRITS Toolbox main build project

GNU General Public License v3.0

1 stars 0 forks source link

Jars with plugin metadata #13

Open ReneRanzinger opened 2 years ago

ReneRanzinger commented 2 years ago

There are two repositories that are clearly jars (used to build jars for bundles) but that have themselves plugin metadata (META-INF/MANIFEST , build.properties):

If this is not needed we should clean them up and make them pure jars.

senaarpinar commented 2 years ago

jar.org.swtchart is being used as a plugin dependency not as a jar file. It is similar to org.grits.toolbox.lib bundle. The jar files you see in this plugin are generated from org.swtchart.src plugin as we have made some changes to the original source code for histograms.
jar.org.grits.toolbox.tools.spectrafiltering on the other hand, is being used as a jar (included in org.grits.toolbox.lib). We can remove the plugin metadata as far as I can tell.

ReneRanzinger commented 2 years ago

That is strange. As far as I can see the jar.org.swtchart is used to build a jar which in turn is part of bundle bundle.org.swtchart. Does this mean some plugins have dependencies on the jar plugin and others/same on the bundle?

senaarpinar commented 2 years ago

Where do you see jar being generated? There is no ant build for this org.swtchart plug-in as far as I can see.

ReneRanzinger commented 2 years ago

there is an ant file in jar.org.swtchart it creates a jar with the pattern org.swtchart${version.number}.b${build.number}.jar_ and version.number is set to 0.9.1. That seem to be the same jar that is included in bundle.org.swtchart.