search

Grocel / 3D-Stream-Radio

It is an spawnable scripted entity for Garry's Mod that allows you to play online streams and local files as 3D world sound.
https://steamcommunity.com/sharedfiles/filedetails/?id=246756300
17 stars 4 forks source link

Show "flac" and "webm" files when browsing sound files #17

Closed somefoolouthere closed 1 year ago

somefoolouthere commented 1 year ago

Allows audio files with the "flac" or "webm" extension to show up when browsing gamesounds on a radio entity or in the playlist editor.

somefoolouthere commented 1 year ago

I found out that radios don't properly stop WebM Opus files when they play to the end. I don't know how to fix this, but I can remove support if you want me to.

Grocel commented 1 year ago

Now I see what you meant. WebM could be confusing to users, because they also could contain videos and not work. BASS and thus this addon doesn't support videos that well, it's made for sound files. BASS is also outdated in the game. See Issue: https://github.com/Facepunch/garrysmod-requests/issues/1885

So when BASS is updated the WebM issue could disappear, but that's just a guess.

The format "flac" is fine, though.

Can you provide me with some test files? Like 3 different ones each format?

BTW: That's good that you commented here again instead of in Workshop. Often Workshop is cancer, with 12 year olds not reading stuff, but whining about impossible to fix problems instead etc.

somefoolouthere commented 1 year ago

I'm not entirely sure what test files you want. Do you just want WebM files, and do you want one including video or one with video only?

As for the WebM playback issue, it seems to just be a visual thing. They still loop fine, although I haven't tested playlist track switching. This issue also applies to AAC, which is commonly found in m4a files.

Grocel commented 1 year ago

I need the file you have the issue with.

somefoolouthere commented 1 year ago

Here you go. Half-Life 2 - Something Secret Steers Us [Remix].webm

To add to my last comment, I tried using it in a playlist, and it doesn't switch to the next track when it ends.

Grocel commented 1 year ago

I can not confirm the issue, It works fine for me in my test. Seeking seems kinda laggy, but I guess that's a bass binary thing. Apparently this webm files seems to run fine for me otherwise. Not sure how files with video data would perform, though.

Can you give me a screenshot/video of your issue of the radio not switching the song?

Edit: I have found a similar issue of that happening on some files, but this is not format depended. It is a timing issue that I will fix for next update. I still need the screenshot/video of your issue, so I can be sure we are taking about the same issue.

As for the suggested changes, I will pull them as soon as the current playback issue has been investigated for fixing.

somefoolouthere commented 1 year ago

It turns out that it was because I had the loop mode set to no loop. I didn't know that it would make tracks not switch to the next one when it ended.

Grocel commented 1 year ago

Don't worry about this. This is intended behavior. But, because I have checked your report in order to reproduce it, I actually found and fixed a now known unrelated bug. It had similar to reported behavior and happened randomly. I will merge the changes, now. 👍