search

GroceriStar / fetch-constants

0 stars 2 forks source link

#### [Groceristar][Grocery][methods] #12

Closed atherdon closed 5 years ago

atherdon commented 5 years ago

By using names on methods from this page In order to make it better, we'll create set of constants, each for a different method.

Example: Method that will Display Grocery List Data will became export const GET_FULL_GROCERY_LIST = "GET_FULL_GROCERY_LIST";

akshatphumbhra commented 5 years ago

Hey,

I saw the issue you linked me to, but I wasn't able to understand exactly what I needed to do. I created a new file and tried to start, but I'm still unsure of what I'm doing. Can you just let me what exactly I'm supposed to do?

https://github.com/akshatphumbhra/fetch-constants/commit/070d28ea9f543ceb6653d8f667970aefeec91284

Thanks, Akshat Phumbhra

atherdon commented 5 years ago

ok, will take a look. while i'm checking your changes - did you know about git-flow and logic of pull requests? i have a good set of tutorials, if you need it - tell me

atherdon commented 5 years ago

yes, this is what we need. but we'll have more constants, and i don't like putting everything in one line. it may be cool, but will be confusing to other people, so please don't save lines :) export will return object with constants. please continue, and when you'll finish it - open a pull request with your changes.

maybe this task looks simple, but you see - it raise another questions as well

akshatphumbhra commented 5 years ago

Hey, Can you send me the tutorials? I'm not very sure about pull requests.

Thanks

atherdon commented 5 years ago

https://github.com/ChickenKyiv/awesome-git-article#forking-pull-requests

atherdon commented 5 years ago

please confirm that we cover all methods from grocery router - so i can close this task

akshatphumbhra commented 5 years ago

Yes, I've covered all the methods from Grocery Router.

Thanks, Akshat Phumbhra

On Mon, 25 Feb 2019 at 20:04, Arthur Tkachenko notifications@github.com wrote:

please confirm that we cover all methods from grocery router - so i can close this task

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/fetch-constants/issues/12#issuecomment-467249431, or mute the thread https://github.com/notifications/unsubscribe-auth/ApzzCzVAg6EHgVfWhTb0bAzJbHTSR5dGks5vRIgYgaJpZM4bOT_6 .

atherdon commented 5 years ago

perfect, closing it