GroceriStar / groceristar-fetch

json arrays for Food Tech projects
https://groceristar.github.io/groceristar-fetch/
GNU General Public License v3.0
8 stars 18 forks source link

upgrade our tests #283

Closed atherdon closed 5 years ago

atherdon commented 5 years ago

here you can see an example, of how we can create a function for similar tests: https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GroceriStar/test/files.test.js Here we need to improve our tests: https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GroceriStar/test/getGroceriesWithDepIngKey.test.js https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GroceriStar/test/gsDepartments.test.js @hirdbluebird

atherdon commented 5 years ago

https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/ChickenKyiv/test/chickenKyiv.test.js

atherdon commented 5 years ago

This is ГЕПЮР this is for me

atherdon commented 5 years ago

getGroceriesWithDepIngKey.test.js

1) it didn't look similar to the shared example 2) some stuff commented but wasn't replaced/improved/updated 3) i have a feeling that it can be better improved.... Let's talk about it

atherdon commented 5 years ago

https://github.com/GroceriStar/groceristar-fetch/pull/288#pullrequestreview-221128339

atherdon commented 5 years ago

so now all these files are updated, right?

atherdon commented 5 years ago

find other files at src/project - where you can do something similar

atherdon commented 5 years ago

Plus, our previous dev left us this issue. I'm sure you can handle it image You can see it here: https://travis-ci.org/GroceriStar/groceristar-fetch/builds/514794236

atherdon commented 5 years ago

image https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GroceriStar/test/getGroceriesWithDepIngKey.test.js#L23-L28 THIS IS A BUG Babel for me

atherdon commented 5 years ago

we still have a lof of bugs. Don't forget to grab latest changes and run yarn install each time.. 1) run yarn test 2) run yarn babel for both cases i see errors

atherdon commented 5 years ago

dick

atherdon commented 5 years ago

fu