search

GroceriStar / groceristar-fetch

json arrays for Food Tech projects
https://groceristar.github.io/groceristar-fetch/
GNU General Public License v3.0
8 stars 18 forks source link

Intro to the project #295

Closed atherdon closed 5 years ago

atherdon commented 5 years ago

You need to read readme file: https://github.com/GroceriStar/groceristar-fetch/blob/master/README.md it also contains links to articles, where I explaining some details. If something will be not clear - don't hesitate and ask questions.

Tasks, that you can take(feel free to ask clarification if something is not clear)

  1. In our previous major release, we change a way how we connect to files. And after that changes, most of our default get methods become obsolete. They also start to generate an issue, because of naming conflict. So our goal with you will be to clean it up. Your part will be related to /projects/chickenkyiv/ChickenKyiv.js file. Here you can see our old methods. RIght now we don't need them. But each of these methods used below in this file. So our goal is to remove them totally from this file, without breaking any logic.

https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/ChickenKyiv/chickenKyiv.js#L17-L47

I have feeling that this will be a simple task for you.

For example, this method contains old, commented version and working well without it https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GroceriStar/groceristar.js#L103-L114

@azaidi4

azaidi4 commented 5 years ago

Hi @atherdon . Essentially you would like me to remove the old getter functions in line 17-47, correct?

atherdon commented 5 years ago

in short yes, but if you will just delete them - you'll crash this part of the project. Take some time and review this file - you'll see that some methods below, related to this get functions. So it's not a simple task and it'll require some attention

atherdon commented 5 years ago

image

azaidi4 commented 5 years ago

I understand that. How do you want me to submit my task, I can fork the project and submit a pull request when I'm done

atherdon commented 5 years ago

yes, please fork project now, and then submit your pull request

atherdon commented 5 years ago

you can also check your changes by running 'yarn test'. right now few of our tests also broken, but you'll be able to see if your changes works fine

azaidi4 commented 5 years ago

@atherdon https://github.com/GroceriStar/groceristar-fetch/pull/303. Travic Cl build failing due to broken tests. Changes work fine

atherdon commented 5 years ago

Ok, while i'm thinking about another task - you can do the same thing, but for https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/MealCalendar/mealCalendar.js file

azaidi4 commented 5 years ago

I have an exam tomorrow, so I might not be able to work on this today. Hope it will be fine

atherdon commented 5 years ago

sure, then take your time - no problem at all. i'll use this time and prepare a list of tasks for you

atherdon commented 5 years ago

305 OK, closing this task and will create something more interesting and complex :) Good luck with exams!