intro to the project

[atherdon]

You need to read readme file: https://github.com/GroceriStar/groceristar-fetch/blob/master/README.md it also contains links to articles, where I explaining some details. If something will be not clear - don't hesitate and ask questions.

Tasks, that you can take(feel free to ask clarification if something is not clear)

1. check @TODO mark that we have at src/projects and let's discuss with me what todo next. @EbrahimKreem

[ebrahim-2]

I apologize for my ignorance but I didn't find the @TODO mark at src/projects @atherdon

[atherdon]

:( how did you look? you can do it by hands, not by search. it'll also help you to understand the project better

[ebrahim-2]

😅 okay I checked the @TODO marks in src/projects so what can I do next

[atherdon]

put on your task 10 todo`s and we'll pick first one to work on it. for each todo, please add a codeline - so i can easily view them

[ebrahim-2]

https://github.com/GroceriStar/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/ChickenKyiv/chickenKyiv.js#L37 I will begin with this because I think it is the easiest

[atherdon]

hold on. re-read my comment carefully.

[ebrahim-2]

Do you want me to list all the 10 todo's with its code lines or what you mean exactly

[atherdon]

yes, put here 10 todo`s

[atherdon]

When you'll put that list here, you can start to work

groceristar-fetch/src/projects/ChickenKyiv/chickenKyiv.js

Line 37 in 5c5ec2d

created_at: Date(), // @TODO we have a module day.js use it instead I will begin with this because I think it is the easiest

---

Please fix it, but in order to make it work as we need, please check how we handle it here: https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GraphQL/graphQL.js#L3 https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GraphQL/graphQL.js#L105-L114

[ebrahim-2]

1) https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/ChickenKyiv/chickenKyiv.js#L37

2) https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/ChickenKyiv/chickenKyiv.js#L38

3) https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/ChickenKyiv/chickenKyiv.js#L78

4) https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/ChickenKyiv/chickenKyiv.js#L98

5) https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/ChickenKyiv/chickenKyiv.js#L110

6) https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/ChickenKyiv/chickenKyiv.js#L118

7) https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/GroceriStar/groceristar.js#L233

8) https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/GroceriStar/groceristar.js#L162

9) https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/Search/search.js#L89

10) https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/Search/search.js#L182

[atherdon]

thanks, just small note - it's better to use codeline from main repo - just in case if other developers change something. But for now it's ok. feel free and complete that first todo and open pull request with your changes to our repository

[atherdon]

did you update code, related to all ten @todos?

[atherdon]

just want to keep hand on pulse

[ebrahim-2]

😓 I'm still stuck in some of them

[atherdon]

then tell me which one and i'll help you. I made that comments for myself, so it can be confusing for sure. And actually we made a lot of progress nowadays, so some comments can be outdated as well

[ebrahim-2]

in the todo number 7 does the functions 'getAllDepartmentsWithId', 'getAllIngredientsWithId' used in other projects? I can make one generic function that does both tasks but I'm afraid to break things in other projects that use this functions

[atherdon]

The easiest way is: 1) create one major function. and just call it at getAllDepartmentsWithId, getAllIngredientsWithId 2) Create a separated issue, that will explain the problem(you can copy your comment) and I'll forward this task to some other team member, that have knowledge about it.

and yeah - moving carefully is a good thing, because this module and our projects evolving, so back compatibility is an important thing for us

[ebrahim-2]

I made a pull request for other todos but number 4,10 I didn't figure out how to update them.

[atherdon]

ok, so 4 and 10 left, right?

[atherdon]

did you create a separated task for https://github.com/GroceriStar/groceristar-fetch/issues/324?

[atherdon]

4. https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/ChickenKyiv/chickenKyiv.js#L98 Here all is simple. For most of our cases - we just want to have a few recipes(five). But i think it's better to have more advanced function, where we can decide ourself - how much element we should have. I also think that these method can be useful in other projects too, so maybe it's better to move a newest version to the helper.js file.

5. https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/Search/search.js#L182 A method like this we're using for displaying select fields. and as it's not a very simple topic - I want to add a test, that can cover this situation. Not sure if you need to work on it. But learning how tests works is a good skill. So it's upon your choice.

[ebrahim-2]

1. https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/ChickenKyiv/chickenKyiv.js#L98 Here all is simple. For most of our cases - we just want to have a few recipes(five). But i think it's better to have more advanced function, where we can decide ourself - how much element we should have. I also think that these method can be useful in other projects too, so maybe it's better to move a newest version to the helper.js file.
2. https://github.com/EbrahimKreem/groceristar-fetch/blob/5c5ec2d6c428c07e63bc53cccd63120975752164/src/projects/Search/search.js#L182 A method like this we're using for displaying select fields. and as it's not a very simple topic - I want to add a test, that can cover this situation. Not sure if you need to work on it. But learning how tests works is a good skill. So it's upon your choice.

okay I will do my best

[ebrahim-2]

did you create a separated task for #324?

what I didn't understand 😅

[atherdon]

ok, i'll do it for you. btw, you can continue with other todos - post a next part here and add your questions, so i can help you

[ebrahim-2]

I'm really confused about the todo number four, not because the implementation of the function but there is a method called getNRecipes that do the work so should I update the getFirstFiveRecipes method to accept a number in order to change the number of recipes that we can return or update the getNRecipes method

[atherdon]

ok, give me some time to think about it. what about workin on a next set of @todos that we have?

[atherdon]

when we'll clean up this module from todos and module will work fine at our projects - i'll assign a cool task to you. I think you'll like it

[ebrahim-2]

ok, give me some time to think about it. what about workin on a next set of @todos that we have? …

ok

[ebrahim-2]

Hi @atherdon, I looked to the custom structures generator [Main task] so is there any tasks for me

[vadim9999]

@EbrahimKreem Hi! I have a task for you https://github.com/GroceriStar/sd/issues/233

[atherdon]

@vadim9999 can we close this task?