Open atherdon opened 5 years ago
You may ask me - how departments file was created? This is an actual task for those departments:
"By using names on methods from this page we created a set of constants. Each constant is just a human version of the method that we have. But we didn't finish work, related to department methods. You'll need to do it.
Example:
Get data, related to single department
equal to export const GET_DEPARTMENT_DATA = "GET_DEPARTMENT_DATA";
"
youre first assesment to this task will be:
By using names on methods from this page In order to make it better, we'll create set of constants, each for a different method.
Example:
Create or find at db new ingredient new ingredient and attach it to grocery list
will became export const FIND_OR_CREATE_AND_ATTACH_TO_GROCERY = "FIND_OR_CREATE_AND_ATTACH_TO_GROCERY";
[Completed] @elnur004 you can grab this one
By using names on methods from this page In order to make it better, we'll create a set of constants, each for a different method.
Example:
Get All ingredients with status favorite
will became export const GET_ALL_FAVORITE_INGREDIENTS = "GET_ALL_FAVORITE_INGREDIENTS ";
@elnur004 another one for you
By using names on methods from this page In order to make it better, we'll create set of constants, each for a different method.
Example:
Method that will Display Grocery List Data
will became export const GET_FULL_GROCERY_LIST = "GET_FULL_GROCERY_LIST";
@elnur004 similar to previous one, but will require some time for research
https://chickenkyiv.github.io/search-api-documentation/docs/db-schema
https://chickenkyiv.github.io/search-api-documentation/docs/db-schema By using names on URLS from this page In order to make it better, we'll create set of constants, each for a different method.
Example:
http://localhost:3000/api/attribute?filter[where][type]=allergy
will became export const ATTRIBUTE_FILTER_TYPE_ALLERGY = "ATTRIBUTE_FILTER_TYPE_ALLERGY";
@elnur004 same thing, but step2
https://chickenkyiv.github.io/search-api-documentation/docs/db-schema
https://chickenkyiv.github.io/search-api-documentation/docs/db-schema By using names on URLS from this page In order to make it better, we'll create set of constants, each for a different method.
Example:
http://localhost:3000/api/attribute?filter[where][type]=allergy
will became export const ATTRIBUTE_FILTER_TYPE_ALLERGY = "ATTRIBUTE_FILTER_TYPE_ALLERGY";
@elnur004 next thing is to create constants for our models: https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/constants.md#models
@siddharthp538 you can grab this part of data. https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/constants.md#models-1 this part is similar to work that was done before here
@atherdon in which file we need to create constants for models? create new files or how?
each new sub-task here is a new file. because in other case we'll be very confused. as you see - we trying to cover a lot of cases an the same time and it's very confusing right now :)
@elnur004 you should continue to work on this task. I think at this file https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/constants.md we have a lot of work to do
Hi @atherdon,
There is an existing depatment.js file under the docs directory, my question is which constants should have to add on that file because I am seeing some constants in that already.
@AkshayChoulwar this was your first task: https://github.com/GroceriStar/groceristar-fetch/issues/448#issuecomment-506798133 departments was just an example, that shows how this task should be done: https://github.com/GroceriStar/groceristar-fetch/issues/448#issuecomment-506797807
but, as you already checking departments - tell me - do all of the methods were transferred? we didn't miss anything?
@atherdon according to this page for departments it's completed.
@atherdon for this task whether we have to create the separate file or should we add to the ingredient.js file.
make a separated file for it please.
Thanks for letting me know about departments
@atherdon thanks for clearing doubts.
@elnur004 do we have something left here for you?
@atherdon i guess we've done all constants and models
@atherdon if this task has been done already, may i get a new one, please?
all things from this file: https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/constants.md? i just not remember what exactly we were working on :) give me more details so I can refresh my memory.
if we finish it - then yeah - i'll find a new task for you
we just created several constants and model files.
so we can do other sections from this file? if yes - then you can jump into it. i'm a bit busy right now - soon will find something more interesting to you
@atherdon need we create constants related to relations for model schemas?
yes, please do it
Is your feature request related to a problem? Please describe. @AkshayChoulwar Sorry for short description, let's explore this task at comments. feel free and ask me anything
right now here we have 2 files that will give you an idea of what we need to do. 1) check this file https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/constants.md we'll use information from it in order to create 50-70 constants before moving to a next stage 2) this is an example of how methods of groceristar - departments entity looks as constants: https://github.com/GroceriStar/groceristar-fetch/blob/master/docs/const-departments-example.js
Is it was created as task at GitHub issues? Please provide an issue number or link
Describe the solution you'd like A clear and concise description of what you want to happen.
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Additional context Add any other context or screenshots about the feature request here.