GroceriStar / react-only-13

GNU General Public License v3.0
0 stars 0 forks source link

Master React, Quick Code tutorial. Part 3 #4

Closed atherdon closed 6 years ago

atherdon commented 6 years ago

https://medium.com/quick-code/lets-learn-react-chapter-3-components-components-components-3492f771d623

Expected result

Test

khyati0212 commented 6 years ago

@atherdon I am not clear what to do for test scenario 2. Can you give some more information?

atherdon commented 6 years ago

Sure, we have a week, and days inside of this week. but how i can system know - what day we send to some method? is it work days(1-5) or weekends(0,6). tell me, are you pass current article? because i don't want to make a spoilers :)

khyati0212 commented 6 years ago

Which article!!

atherdon commented 6 years ago

i assume you read react chapter 3 - but you didn't post a code on repo, right?

khyati0212 commented 6 years ago

Yes. I did till MonthChecker. Than i had to leave.. Going on weekend holiday.. šŸ™‚

atherdon commented 6 years ago

Good to know! Enjoy your holidays, have fun and recharge your energy.

On 27-Apr-2018 at 11:49 PM, Khyati wrote:

Yes. I did till MonthChecker. Than i had to leave.. Going on weekend holiday.. šŸ™‚

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/react-only-13/issues/4#issuecomment-385120827, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDl9pYPz-kwQqUuKMsr3ZZAhdDxCvks5ts66TgaJpZM4Tl_qt .

khyati0212 commented 6 years ago

Thank you..

khyati0212 commented 6 years ago

@atherdon Could you check the commit.

  1. Separated the functionality of day checker, month checker, week checker and Header.
  2. All the files DayChecker, MonthCheck, WeekChecker and Header are imported into App.js.
  3. They are wrapped in
    to interpreter it correctly.
  4. Created separate folder /components/data/ to include all days and months array using days.js and months.js.
  5. Data is extracted from days.js and months.js.

Output:

This app will tel you if you should work today Today is Saturday It is Weekend Month is May

atherdon commented 6 years ago

App.js should be in root of src folder. it's not a component

all is good. i like to see this progress! Btw, i pushed a latest article - and it's related to our converstation about db schemes. please take a look

khyati0212 commented 6 years ago

Yes i saw the article. It's really good.

I will move App.js out of component folder. Any other changes needed.

atherdon commented 6 years ago

nope. this task can be closed and you can move to a next one

On 06-May-2018 at 06:09 AM, Khyati wrote:

Yes i saw the article. It's really good.

I will move App.js out of component folder. Any other changes needed.

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/react-only-13/issues/4#issuecomment-386856783, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDphk-tR_q-3Fp18_zryXr3KzpaVlks5tvpOwgaJpZM4Tl_qt .