GroceriStar / types

GNU General Public License v3.0
0 stars 4 forks source link

ingredient relation #21

Open Yoimer opened 6 years ago

Yoimer commented 6 years ago

Please ignore comments in the json. Just check it out and let me know anything.

atherdon commented 6 years ago

5

Ok, i reviewed it. It's not exactly what i want to get here. Related to your comments at json - PersistedModel it's a basic class, that used in Loopback Framework. In this class described a basic CRUD related methods(Add, delete, edit, update, update in bulk) and when this class read our json file(it's basically a config, that describe logic of our database table), it creates a model, setup a basic relations and register main fields in the system. it's important when you don't want to have a system, that not related to one language, for creating a DB schema.

Ok, so what you should do here. let's for example check the ingredient.json file. We have one relation with departments. we're creating a constant, that will be responsible later for that relation. const INGREDIENT_DEPARTMENT_RELATION = 'INGREDIENT_DEPARTMENT_RELATION';

you should add that line to file, that we have in this repo.

Tell me if this is not clear, i can explain or create a video for you

Yoimer commented 6 years ago

Arthur, A video would be great for me if it does not mean a problem for you. Thanks a lot. I am willing to help in this project.

On Wed, Jul 25, 2018 at 8:05 AM, Arthur Tkachenko notifications@github.com wrote:

5 https://github.com/GroceriStar/types/issues/5

Ok, i reviewed it. It's not exactly what i want to get here. Related to your comments at json - PersistedModel it's a basic class, that used in Loopback Framework. In this class described a basic CRUD related methods(Add, delete, edit, update, update in bulk) and when this class read our json file(it's basically a config, that describe logic of our database table), it creates a model, setup a basic relations and register main fields in the system. it's important when you don't want to have a system, that not related to one language, for creating a DB schema.

Ok, so what you should do here. let's for example check the ingredient.json file. We have one relation with departments. we're creating a constant, that will be responsible later for that relation. const INGREDIENT_DEPARTMENT_RELATION = 'INGREDIENT_DEPARTMENT_RELATION';

you should add that line to file, that we have in this repo.

Tell me if this is not clear, i can explain or create a video for you

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-407731382, or mute the thread https://github.com/notifications/unsubscribe-auth/ASSSpXdIZcXiNQuGQGjzyEmUMM7BzPEPks5uKF8hgaJpZM4VbmLx .

atherdon commented 6 years ago

ok, i'll do it. btw, you can address another issue while i'm preparing a video for you

Yoimer commented 6 years ago

Great. Which issue would it be? I am willing to learn about this Loopback Framewok thing though.

On Thu, Jul 26, 2018 at 8:25 AM, Arthur Tkachenko notifications@github.com wrote:

ok, i'll do it. btw, you can address another issue while i'm preparing a video for you

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-408079893, or mute the thread https://github.com/notifications/unsubscribe-auth/ASSSpYOOCM22Z5IcOEgI9r7_Bq05l2mdks5uKbVPgaJpZM4VbmLx .

atherdon commented 6 years ago

to be honest, we're trying to 'kill' our 3 REST APis that ws build with loopback. we're trying to move into graphQL approach. I'm also created a course for my interns. if you interested - i can setup a separate instance for you too.

https://github.com/GroceriStar/types/issues/22

On 26-Jul-2018 at 12:29 PM, Yoimer wrote:

Great. Which issue would it be? I am willing to learn about this Loopback Framewok thing though.

On Thu, Jul 26, 2018 at 8:25 AM, Arthur Tkachenko notifications@github.com

wrote:

ok, i'll do it. btw, you can address another issue while i'm preparing a video for you

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-408079893, or mute the thread < https://github.com/notifications/unsubscribe-auth/ASSSpYOOCM22Z5IcOEgI9r7_Bq05l2mdks5uKbVPgaJpZM4VbmLx>

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-408080910, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDiR51pUlVfcJUubQ8BbL4WDb2bCKks5uKbY1gaJpZM4VbmLx .

Yoimer commented 6 years ago

Please create an instance for me too if possible. I will start looking on my own about GraphSQL in order to get the approach a bit quicker.

On Thu, Jul 26, 2018 at 8:35 AM, Arthur Tkachenko notifications@github.com wrote:

to be honest, we're trying to 'kill' our 3 REST APis that ws build with loopback. we're trying to move into graphQL approach. I'm also created a course for my interns. if you interested - i can setup a separate instance for you too.

https://github.com/GroceriStar/types/issues/22

On 26-Jul-2018 at 12:29 PM, Yoimer wrote:

Great. Which issue would it be? I am willing to learn about this Loopback Framewok thing though.

On Thu, Jul 26, 2018 at 8:25 AM, Arthur Tkachenko < notifications@github.com>

wrote:

ok, i'll do it. btw, you can address another issue while i'm preparing a video for you

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-408079893, or mute the thread < https://github.com/notifications/unsubscribe-auth/ASSSpYOOCM22Z5IcOEgI9r7_ Bq05l2mdks5uKbVPgaJpZM4VbmLx>

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-408080910, or mute the thread https://github.com/notifications/unsubscribe-auth/ ABZrDiR51pUlVfcJUubQ8BbL4WDb2bCKks5uKbY1gaJpZM4VbmLx .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-408082383, or mute the thread https://github.com/notifications/unsubscribe-auth/ASSSpcbDtQ0SoE91Z2NUpk9ZEr5xT_AFks5uKbeZgaJpZM4VbmLx .

atherdon commented 6 years ago

done: https://github.com/GroceriStar/playing-with-graphql/issues/19

On 26-Jul-2018 at 12:39 PM, Yoimer wrote:

Please create an instance for me too if possible. I will start looking on my own about GraphSQL in order to get the approach a bit quicker.

On Thu, Jul 26, 2018 at 8:35 AM, Arthur Tkachenko notifications@github.com

wrote:

to be honest, we're trying to 'kill' our 3 REST APis that ws build with loopback. we're trying to move into graphQL approach. I'm also created a course for my interns. if you interested - i can setup a separate instance for you too.

https://github.com/GroceriStar/types/issues/22

On 26-Jul-2018 at 12:29 PM, Yoimer wrote:

Great. Which issue would it be? I am willing to learn about this Loopback Framewok thing though.

On Thu, Jul 26, 2018 at 8:25 AM, Arthur Tkachenko < notifications@github.com>

wrote:

ok, i'll do it. btw, you can address another issue while i'm preparing a video for you

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-408079893, or mute the thread < https://github.com/notifications/unsubscribe-auth/ASSSpYOOCM22Z5IcOEgI9r7_ Bq05l2mdks5uKbVPgaJpZM4VbmLx>

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-408080910, or mute the thread https://github.com/notifications/unsubscribe-auth/ ABZrDiR51pUlVfcJUubQ8BbL4WDb2bCKks5uKbY1gaJpZM4VbmLx .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-408082383, or mute the thread < https://github.com/notifications/unsubscribe-auth/ASSSpcbDtQ0SoE91Z2NUpk9ZEr5xT_AFks5uKbeZgaJpZM4VbmLx>

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/21#issuecomment-408083440, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDiBRLdAzbYjIqTPUh358jByZplfpks5uKbiSgaJpZM4VbmLx .