search

GroceriStar / types

GNU General Public License v3.0
0 stars 4 forks source link

revision for ingredient model schema #9

Open Yoimer opened 6 years ago

Yoimer commented 6 years ago

Added recipe-model-schema.json as based code for next ones Added ingredient as I think it should be base from db schema and my experience, which it is not that rich yet on the db arena. Please feel free to correct anything from this. If this is what it is expected, I move forward. Thanks

Yoimer commented 6 years ago

One last comment, I know comments are not allowed in a json file. I just typed them on the 9a9029b commit for emphasizing what I did not understand from db schema. Thanks

Yoimer commented 6 years ago

Sure thing. I will use cherry-pick commit next time. Thanks

On Sun, Jul 22, 2018, 22:46 Arthur Tkachenko notifications@github.com wrote:

@atherdon requested changes on this pull request.

Can you make a separated pull request - just with commits, related to meal calendar functionality?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/9#pullrequestreview-139319236, or mute the thread https://github.com/notifications/unsubscribe-auth/ASSSpYKrYztvC95tf0fUGjy98rADGPCDks5uJTkigaJpZM4VVi5V .

atherdon commented 6 years ago

it's not a problem, just think that this will be interesting for you too. also will extend your git knowledge

atherdon commented 6 years ago

Btw, tell me if you need a next task. i think soon i'll be ready to give you something more interesting and complex

Yoimer commented 6 years ago

I do need a next task. Shoot it just after I commit the first one. Thanks

On Mon, Jul 23, 2018 at 12:12 AM, Arthur Tkachenko <notifications@github.com

wrote:

Btw, tell me if you need a next task. i think soon i'll be ready to give you something more interesting and complex

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/types/pull/9#issuecomment-406933925, or mute the thread https://github.com/notifications/unsubscribe-auth/ASSSpYhMVpKjHhPicLFg-wEp6_aADysPks5uJU0dgaJpZM4VVi5V .