search

GroenteLepel / qiskit-quantum-knn

A pure quantum knn classifier for a gated quantum computer.
Apache License 2.0
22 stars 8 forks source link

[fix]: update libs and remove aqua from examples #16

Closed ErmachenkoBoris closed 2 years ago

ErmachenkoBoris commented 2 years ago

Updated requirments.txt and change import QuantumInstance from aqua to utils

GroenteLepel commented 2 years ago

Qiskit Aqua is till in the tests, so the checks fail trying to merge this.

ErmachenkoBoris commented 2 years ago

Qiskit Aqua is till in the tests, so the checks fail trying to merge this.

Ok, I see, I will fix

ErmachenkoBoris commented 2 years ago

@GroenteLepel Hi, will you approve?

GroenteLepel commented 2 years ago

Sorry for the late reply. This is strange, because the error that is being generated is an aqua.AquaError(). If it works on your side than I’ll just merge this and accept that my tests are just not written for this kind of migration.

ErmachenkoBoris commented 2 years ago

My bad, I find an error, sorry, will return with new fix

ErmachenkoBoris commented 2 years ago

@GroenteLepel Hello, I tried to get rid of qiskit aqua completely: 1) abstract classes QuantumAlgorithm and _QSVM_ABC - I didn't find them in the new version of qiskit - I just copied them from qiskit.aqua and created special files for them 2) the get_subsystems_counts function - also not found in the latest version of qiskit. Solution: created a utils file and copied get_subsystems_counts from qiskit.aqua 3) AquaError -> ValueError

GroenteLepel commented 2 years ago

Thank you for this, very good.

ErmachenkoBoris commented 2 years ago

Thank you for your library and for your excellent scientific work - I am doing my master's work in this field and it helps me a lot