Grokzen / docker-redis-cluster

Dockerfile for Redis Cluster (redis 3.0+)
MIT License
1.47k stars 550 forks source link

Tls fix #103

Closed instagrim-dev closed 4 years ago

instagrim-dev commented 4 years ago

continuation of the efforts started in https://github.com/Grokzen/docker-redis-cluster/issues/99

Grokzen commented 4 years ago

@wheelpharaoh Hi just checking a few things so i understand what is added.

If TLS is set to be enabled it will replace the normal redis config template with this new TLS specific version right and just bind to same IP/PORT as the normal nodes on port 7000-7006 right?

It looks like in your TLS template file that you bind to port 0, is that an oversight on your part? The normal template file renders the port into the file on disk, in your case we would not know what port was bound on the inside?

Grokzen commented 4 years ago

@wheelpharaoh Why you close this issue? There is no need to close it down, just make your changes and force push it to the same branch and it will be sorted out