search

Groovin-Dev / TeamsExpansion

GNU General Public License v3.0
0 stars 0 forks source link

Certain placeholders are not working #1

Closed Gitberham closed 3 months ago

Gitberham commented 4 months ago

%team_prefix% and %team_suffix% output these technical terms instead of the proper prefix and suffix. image

Also, %teamcount% does not seem to work. It only detects the team the player is currently is in, similar to %team_count%

Groovin-Dev commented 4 months ago

Hey, it's been quite a while since I touched this project and actually forgot about it.

I'll take a look to see if something has changed.

Could you also lmk how you found this repo? Kind of curious

Groovin-Dev commented 4 months ago

@Gitberham Updated. Can you take a look now?

Gitberham commented 4 months ago

Thank you! The prefix and suffix placeholders now work, however, the set color does not display image

Also, %teamcount(team_name)% still doesn't work, it still only detects the team a player is currently in.

To answer your question; I found this repo through the original TeamsExpansion repo in both opened issues, where you linked your repo to announce you fixed some ongoing problems.

Gitberham commented 4 months ago

Any update on this? @Groovin-Dev

Groovin-Dev commented 4 months ago

Could you show the color you are setting the team to? Also, are you running %team_count_(team_name)% exactly or passing a team name like %team_count_testname%

I tested with aqua and my own test teams and got the expected results

Gitberham commented 4 months ago

So, with the color I mean the color formatting set when applying the prefix/suffix using the /team modify. It simply displays as white symbols/characters, even though I set it to be colored text.

Also, I'm currently in a team called MG_BlockFinder, which has two members (me and an armor stand). The test I'm running here is %team_count_Hi% which has 0 members, and %team_count_MG_CraftWare%, which has 1 member. Typing out both these placeholders always shows as 2. Leaving the team I'm currently in makes the %team_count% and %team_count_teamname% placeholder output the placeholder, and not a number.

Gitberham commented 4 months ago

It also appears that whilst a player is not in a team, it outputs the entire placeholder instead of a blank message. image

@Groovin-Dev

Groovin-Dev commented 4 months ago

Just pushed a change. Tested without being in a team and in a team. lmk if that solves your issues

Gitberham commented 4 months ago

Awesome! Thank you, the count placeholder now correctly reads the team name.

Prefixes and suffixes are still missing the proper formatting, the circle is still white instead of the color I chose for it. image

EDIT: The %team_count_teamname% placeholder can not be parsed as a non-player. image

[22:48:05 ERROR]: null org.bukkit.command.CommandException: Unhandled exception executing command 'papi' in plugin PlaceholderAPI v2.11.5 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:155) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_20_R3.CraftServer.dispatchCommand(CraftServer.java:999) ~[paper-1.20.4.jar:git-Paper-461] at org.bukkit.craftbukkit.v1_20_R3.command.BukkitCommandWrapper.run(BukkitCommandWrapper.java:64) ~[paper-1.20.4.jar:git-Paper-461] at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.2.9.jar:?] at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:32) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:19) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.commands.execution.CommandQueueEntry.a(CommandQueueEntry.java:5) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:101) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:434) ~[?:?] at net.minecraft.commands.Commands.performCommand(Commands.java:336) ~[?:?] at net.minecraft.commands.Commands.performCommand(Commands.java:323) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.performChatCommand(ServerGamePacketListenerImpl.java:2230) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$14(ServerGamePacketListenerImpl.java:2190) ~[?:?] at net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:59) ~[?:?] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1465) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:194) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1442) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1365) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?] at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1343) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1232) ~[paper-1.20.4.jar:git-Paper-461] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[paper-1.20.4.jar:git-Paper-461] at java.lang.Thread.run(Thread.java:840) ~[?:?] Caused by: java.lang.NullPointerException: Parameter specified as non-null is null: method dev.groovin.teamsexpansion.TeamsExpansion.onPlaceholderRequest, parameter player at dev.groovin.teamsexpansion.TeamsExpansion.onPlaceholderRequest(Plugin.kt) ~[?:?] at me.clip.placeholderapi.PlaceholderHook.onRequest(PlaceholderHook.java:35) ~[PlaceholderAPI-2.11.5.jar:?] at me.clip.placeholderapi.replacer.CharsReplacer.apply(CharsReplacer.java:119) ~[PlaceholderAPI-2.11.5.jar:?] at me.clip.placeholderapi.PlaceholderAPI.setPlaceholders(PlaceholderAPI.java:71) ~[PlaceholderAPI-2.11.5.jar:?] at me.clip.placeholderapi.commands.impl.local.CommandParse.evaluateParseSingular(CommandParse.java:117) ~[PlaceholderAPI-2.11.5.jar:?] at me.clip.placeholderapi.commands.impl.local.CommandParse.evaluate(CommandParse.java:57) ~[PlaceholderAPI-2.11.5.jar:?] at me.clip.placeholderapi.commands.PlaceholderCommandRouter.onCommand(PlaceholderCommandRouter.java:114) ~[PlaceholderAPI-2.11.5.jar:?] at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?] ... 29 more

Groovin-Dev commented 4 months ago

@Gitberham try now

Gitberham commented 4 months ago

Works great now! Thank you so much for the adjustments and the quick help, I seriously owe you. Do you have plans on publishing this to the eCloud?

Groovin-Dev commented 4 months ago

I just looked at it and probably not. Signups are closed and to be honest this isn't a project I would want to get a ton of issues on. If more people really wanted it then maybe or maybe I could do a GH action to auto build but for now I'm not going to do anything.