search

Groovy-Emacs-Modes / groovy-emacs-modes

A groovy major mode, grails minor mode, and a groovy inferior mode.
84 stars 39 forks source link

Fix indentation and slashy string following || (logical-or) operator. #113

Closed djlindstr closed 6 years ago

djlindstr commented 6 years ago

I noticed that the indentation on a line following || is incorrect, but it works for &&:

assert x ||
y

assert x &&
    y

I suspect that the "!!" in two places in groovy-mode.el should be "||". It seems to fix the indentation, as well as a similar issue with slashy strings.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 95.736% when pulling 85bd862f93e31090385f95b60728f1e408b0237a on djlindstr:fix_logical_or_operator into 7ac48be3bfd2653422de7ef696827e49f4fbf273 on Groovy-Emacs-Modes:master.

Wilfred commented 6 years ago

I think you're entirely correct :)

Thanks!