search

Groovy-Emacs-Modes / groovy-emacs-modes

A groovy major mode, grails minor mode, and a groovy inferior mode.
84 stars 39 forks source link

Ensure that we highlight dollar-slashy-strings correctly #117

Closed Wilfred closed 6 years ago

Wilfred commented 6 years ago

This had no tests before, and it had been broken.

Fix the logic by always calling the dollar-slashy-string functions first, but delegate to slashy-string-function where appropriate.

Add a test, and also split out a test from groovy-highlight-slashy-string for the case when we mix slashy-strings with $. This is easy to break, so having a separate test makes it easier to spot what's wrong.

Aggressively comment this logic, because it's challenging to work with.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+3.0%) to 98.897% when pulling 362c0d28a572b206079404cfed80968a2c8872a5 on slashy-and-dollar-slashy-strings into 6e13837df758cec9d4204f34d9f5f52f70f09521 on master.