Groovy-Emacs-Modes / groovy-emacs-modes

A groovy major mode, grails minor mode, and a groovy inferior mode.
84 stars 39 forks source link

Leave Jenkinsfile alone #146

Closed wyuenho closed 2 years ago

wyuenho commented 2 years ago

The regex currently will match any file that contains the substring Jenkinsfile, which means when I visit jenkinsfile-mode.el, the major mode will switch to groovy-mode even when I'm looking at an elisp file.

There's a much better mode for Jenkins out there already, leave syntax highlighting to that mode.

Wilfred commented 2 years ago

Thanks for the report! Users are free to load other packages and choose what to prioritise in auto-mode-alist, but I agree we shouldn't match other files.

kurnevsky commented 2 years ago

@Wilfred you just broke Jenkinsfile matching :) This regex matches full path, so instead ^ there should be /.