search

Groovy-Emacs-Modes / groovy-emacs-modes

A groovy major mode, grails minor mode, and a groovy inferior mode.
84 stars 39 forks source link

Change groovy-mode to be a standalone mode. #35

Closed Wilfred closed 7 years ago

Wilfred commented 7 years ago

As discussed in https://github.com/Groovy-Emacs-Modes/groovy-emacs-modes/issues/26#issuecomment-283393650 I'm having a go at modifying groovy-mode so it doesn't depend on cc-mode.

This has fixed all of the open highlighting bugs in this repo, and it should fix #11 too.

Let me know what you think.

Edit: now includes indentation logic.

russel commented 7 years ago

I think for the moment I should merge this into a new branch in this mainline repository. People willing to test the mode (including me) can then use the branch rather than master. This would entail me merging this pull request on my clone, pushing to mainline, and then apparently rejecting this pull request.

Does that make sense and seem reasonable?

Wilfred commented 7 years ago

Yep, that makes sense, thanks.

Wilfred commented 7 years ago

@russel I've added indentation logic, so as far as I'm concerned this is done! :)

This should fix #10, #22 and the second case mentioned in #16.

russel commented 7 years ago

As agreed I have created a new branch in this mainline repository with this changeset in and so I am rejecting this pull request (since it is posted against master). I will amend the README.md in master and post an email to the Groovy mailing list to see if we can get people to use the new version and report back.