search

Groovy-Emacs-Modes / groovy-emacs-modes

A groovy major mode, grails minor mode, and a groovy inferior mode.
84 stars 39 forks source link

fix c-lang-defconst issues (emacs 25?) #36

Closed joodie closed 7 years ago

joodie commented 7 years ago

Quoted c-lang-defconst values are causing issues for me on emacs

  1. Not exactly sure why, but since the documentation states the values should not be quoted, I changed all invocations to use (list...) instead and that fixes the issue.

Original error message was:

File mode specification error: (invalid-function (quote (true false null)))

Wilfred commented 7 years ago

@joodie have you tried my patches in #35? This should just work, as it removes the dependency on cc-mode entirely.

russel commented 7 years ago

@Wilfred Do you think it is OK to merge this pull request into master?

Wilfred commented 7 years ago

@russel yep, this patch is very innocuous. I just wanted to draw attention to that fact that this issue doesn't exist on the standalone_mode branch and @joodie might find the bugfixes on that branch to be useful.

joodie commented 7 years ago

Hi @Wilfred - I saw your branch but haven't checked it out it yet. I will try it out and let you know. My main goal is to get groovy-mode from melpa-stable to work with Emacs 25.

russel commented 7 years ago

My problem just now is that I am using @Wilfred mode (in which I get a problem but this may be a configuration problem at my end), so it is not easy for me to check. I'll merge and "fingers crossed".