search

Groovy-Emacs-Modes / groovy-emacs-modes

A groovy major mode, grails minor mode, and a groovy inferior mode.
84 stars 39 forks source link

cl-macroexpand-all is void #7

Closed kaidamasaki closed 9 years ago

kaidamasaki commented 9 years ago

It looks like cl-macroexpand-all has been renamed macroexpand-all in emacs 24.3.

This causes groovy-mode to fail to load.

russel commented 9 years ago

Neither cl-macroexpand-all nor macroexpand-all appear in the current Groovy modes file set. Where do you get yours from? Are you perhaps seeing the same thing as Issue #4 ?

kaidamasaki commented 9 years ago

Not sure. I installed the package from Melpa and it claims to be 20141207.21

Here's the actual error I'm getting:

^L
Compiling file /Users/kaida/.emacs.d/elpa/groovy-mode-20141207.21/groovy-electric.el at Tue Dec  9 09:34:38 2014
Entering directory `/Users/kaida/.emacs.d/elpa/groovy-mode-20141207.21/'
groovy-electric.el:55:1:Error: Symbol's function definition is void: cl-macroexpand-all
^L
Compiling file /Users/kaida/.emacs.d/elpa/groovy-mode-20141207.21/groovy-mode.el at Tue Dec  9 09:34:38 2014
groovy-mode.el:99:1:Error: Symbol's function definition is void: cl-macroexpand-all
^L
Compiling file /Users/kaida/.emacs.d/elpa/groovy-mode-20141207.21/inf-groovy.el at Tue Dec  9 09:34:38 2014
inf-groovy.el:51:1:Error: Symbol's function definition is void: cl-macroexpand-all
russel commented 9 years ago

I think we can ignore the errors in groovy-electric.el and inf-groovy.el since they are both just "includes" of the groovy-mode.el file.

MELPA's copy of groovy-mode.el that you are downloading looks to be identical to Git master/HEAD, which seems entirely good per se. However I see nothing about line 99 of that file that would cause the error you are seeing. Also if I byte compile the file it just works. However if I batch-byte-compile the file I see the error. So we can consider this reproducible, I just have no idea currently what is wrong and how to fix it. Time for some deep research…

russel commented 9 years ago

I have found this to be a not uncommon problem that is supposedly fixed in Emacs 24.5. I have provided a fix for Emacs 24.[0-4], at least the error is gone for me on 24.3. So I claim that this bug is now fixed in master/HEAD. I am not sure how long it will take MELPA to update.

kaidamasaki commented 9 years ago

Awesome, thanks!

On Tue, Dec 9, 2014 at 11:38 AM, Russel Winder notifications@github.com wrote:

I have found this to be a not uncommon problem that is supposedly fixed in Emacs 24.5. I have provided a fix for Emacs 24.[0-4], at least the error is gone for me on 24.3. So I claim that this bug is now fixed in master/HEAD. I am not sure how long it will take MELPA to update.

— Reply to this email directly or view it on GitHub https://github.com/Groovy-Emacs-Modes/groovy-emacs-modes/issues/7#issuecomment-66343658 .

russel commented 9 years ago

I am not seeing a problem of this sort in 24.5.1 on Debian Sid. I shall close this now, please reopen if this specific problem is not fixed as it is believed to be.