Fix various issues with slashy strings

Groovy-Emacs-Modes / groovy-emacs-modes

A groovy major mode, grails minor mode, and a groovy inferior mode.

84 stars 39 forks source link

Fix various issues with slashy strings #74

Closed vincekd closed 7 years ago

vincekd commented 7 years ago

fix slashy-strings that end in $/
handle slashy string /s vs division /s
fix indentation when line ends in a slashy-string (not infix)

coveralls commented 7 years ago

Coverage decreased (-1.7%) to 84.167% when pulling 0f56465e881ff384bad1c5b449f0a0c85b8ec3cf on vincekd:slashy-string-fix into 2fe72a1c6f677868f1123b0b7a8e6441a6d85eaa on Groovy-Emacs-Modes:master.

Wilfred commented 7 years ago

Bah, losing 1.7% test coverage shouldn't fail the build. I've changed the Coveralls settings.

coveralls commented 7 years ago

Coverage increased (+5.8%) to 91.667% when pulling b628a960646b141630b04c9f24c8b9dded5c1882 on vincekd:slashy-string-fix into 2fe72a1c6f677868f1123b0b7a8e6441a6d85eaa on Groovy-Emacs-Modes:master.

Wilfred commented 7 years ago

@vincekd great debugging, thank you! I've added some unit tests on your branch, so these issues stay fixed :)