Declaration variables highlights

vincekd commented 7 years ago

replacement for PR https://github.com/Groovy-Emacs-Modes/groovy-emacs-modes/pull/88 that (hopefully) addresses issues raised there.

[fix #85]

coveralls commented 7 years ago

Coverage increased (+2.6%) to 95.259% when pulling 4df9697b2d0ddd13842613be22afec1f8a3d3251 on vincekd:declaration-variables-highlights into 60e71008db67407de8abf897dbe36cdb66c16e72 on Groovy-Emacs-Modes:master.

coveralls commented 7 years ago

Coverage decreased (-43.6%) to 49.138% when pulling 54c6f00e06f3cd947aed67347974d4dc377dd319 on vincekd:declaration-variables-highlights into 60e71008db67407de8abf897dbe36cdb66c16e72 on Groovy-Emacs-Modes:master.

coveralls commented 7 years ago

Coverage increased (+2.6%) to 95.259% when pulling 689f52045f56b9eb791cc7643162e9322db948c9 on vincekd:declaration-variables-highlights into 60e71008db67407de8abf897dbe36cdb66c16e72 on Groovy-Emacs-Modes:master.

Wilfred commented 7 years ago

Fantastic, thank you :)

glasser commented 7 years ago

I've updated to a version that has this, and I'm now getting these errors when I open a Gradle file:

Debugger entered--Lisp error: (void-variable groovy-declaration-regexp)
  groovy-declaration-search(2259)
  font-lock-fontify-keywords-region(1539 2259 nil)
  font-lock-default-fontify-region(1539 2259 nil)
  font-lock-fontify-region(1539 2259 nil)
  smerge-mode(1)
  smerge-start-session()
  vc-git-find-file-hook()
  apply(vc-git-find-file-hook nil)
  vc-call-backend(Git find-file-hook)
  vc-refresh-state()
  run-hooks(find-file-hook)
  after-find-file(nil t)
  find-file-noselect-1(#<buffer build.gradle> "~/Projects/Meteor/monorepo/go/build.gradle" nil nil "~/Projects/Meteor/monorepo/go/build.gradle" (8927342 16777220))
  find-file-noselect("/Users/glasser/Projects/Meteor/monorepo/go/build.gradle")
  (or (get-file-buffer file) (find-file-noselect file))
  (if (and (not force-worktree) (stringp rev)) (magit-find-file-noselect rev file) (or (get-file-buffer file) (find-file-noselect file)))
  (let* ((hunk (magit-diff-visit--hunk)) (line (and hunk (magit-diff-hunk-line hunk))) (col (and hunk (magit-diff-hunk-column hunk))) (rev (if (and magit-diff-visit-previous-blob (magit-section-match (quote hunk)) (save-excursion (goto-char (line-beginning-position)) (looking-at "-"))) (magit-diff-visit--range-beginning) (magit-diff-visit--range-end))) (buf (if (and (not force-worktree) (stringp rev)) (magit-find-file-noselect rev file) (or (get-file-buffer file) (find-file-noselect file))))) (magit-display-file-buffer buf) (let ((save-selected-window--state (internal--before-with-selected-window (or (get-buffer-window buf (quote visible)) (error "File buffer is not visible"))))) (save-current-buffer (unwind-protect (progn (select-window (car save-selected-window--state) (quote norecord)) (if line (progn (setq line ...) (let ... ...))) (if (magit-anything-unmerged-p file) (progn (smerge-start-session))) (run-hooks (quote magit-diff-visit-file-hook))) (internal--after-with-selected-window save-selected-window--state)))))
  (if (magit-file-accessible-directory-p file) (magit-diff-visit-directory file other-window) (let* ((hunk (magit-diff-visit--hunk)) (line (and hunk (magit-diff-hunk-line hunk))) (col (and hunk (magit-diff-hunk-column hunk))) (rev (if (and magit-diff-visit-previous-blob (magit-section-match (quote hunk)) (save-excursion (goto-char ...) (looking-at "-"))) (magit-diff-visit--range-beginning) (magit-diff-visit--range-end))) (buf (if (and (not force-worktree) (stringp rev)) (magit-find-file-noselect rev file) (or (get-file-buffer file) (find-file-noselect file))))) (magit-display-file-buffer buf) (let ((save-selected-window--state (internal--before-with-selected-window (or (get-buffer-window buf ...) (error "File buffer is not visible"))))) (save-current-buffer (unwind-protect (progn (select-window (car save-selected-window--state) (quote norecord)) (if line (progn ... ...)) (if (magit-anything-unmerged-p file) (progn ...)) (run-hooks (quote magit-diff-visit-file-hook))) (internal--after-with-selected-window save-selected-window--state))))))
  magit-diff-visit-file("/Users/glasser/Projects/Meteor/monorepo/go/build.gradle" nil)
  funcall-interactively(magit-diff-visit-file "/Users/glasser/Projects/Meteor/monorepo/go/build.gradle" nil)
  #<subr call-interactively>(magit-diff-visit-file nil nil)
  apply(#<subr call-interactively> magit-diff-visit-file (nil nil))
  call-interactively@ido-cr+-record-current-command(#<subr call-interactively> magit-diff-visit-file nil nil)
  apply(call-interactively@ido-cr+-record-current-command #<subr call-interactively> (magit-diff-visit-file nil nil))
  call-interactively(magit-diff-visit-file nil nil)
  command-execute(magit-diff-visit-file)

I'm not really sure how eval-when-compile works but I guess it isn't for me? I am loading groovy-mode via melpa.

Groovy-Emacs-Modes / groovy-emacs-modes

Declaration variables highlights #92