1.20.1 FORGE 47.1.0 - 1.43 Crashes with Valkyrien Skies 1.20.1 MOD loaded

[Bannta]

GroovyModLoader appears to conflict with Valkyrien Skies mod causing a hard Game Crashed Error in the client with an Exit Code 1.

During Forge compiling function "Scanning Mod Candidates" Everything appears to map properly then it goes into the scanning mod candidates and immediately crashes the client. [22:31:00] [main/INFO]: Starting runtime mappings setup... [22:31:00] [main/INFO]: Injecting ScriptModLocator candidates... [22:31:00] [main/INFO]: Injected Jimfs file system [22:31:00] [main/INFO]: Injected ScriptModLocator mod candidates. Found 0 valid mod candidates and 0 broken mod files. [22:31:01] [GML Mappings Thread/INFO]: Loaded runtime mappings in 1139ms [22:31:01] [GML Mappings Thread/INFO]: Finished runtime mappings setup. <then nothing follows, crash> latest.log

No crash reports logged

Modpack: https://legacy.curseforge.com/minecraft/modpacks/hopcraft-1-20-1

Testing run on 1-20-1-3.0, however, I narrow it down recently to the GML mod I believe on version 2.2 HopCraft-1.20.1-3.0 [FORGE] You can use this, just add GML to it.

I hope this helps, I really like the Eating Animation mod. Unfortunately playing my modpack as a vampire so I'm not currently eating much food at the moment. Regards,

[HereToSaySomething]

I also am having this same issue.

[lukebemish]

Can you confirm whether the issue persists with the new GML version, 4.0.9? I'll try to look into it

[lukebemish]

Closing this issue due to inactivity; given that quite a lot of issues regarding mappings were fixed with 4.0.9 (and 4.0.10), I'll assume this was too. Feel free to re-open it with more information, and a log with one of those versions.

[oOBoomberOo]

I can confirm having the same issue when using both Valkyrien Skies and GML in 4.0.9.

Strangely, the actual error message did not get logged into the log or crash report file, but it does appear in Launcher's output, which is related to a missing Jackson module.

main | Successfully made module authlib transformable
GML Mappings Thread | Loaded runtime mappings in 1404ms
GML Mappings Thread | Finished runtime mappings setup.
--- message after this line do not appear in latest.log
main | Exception in thread "main" java.lang.module.FindException: Module com.fasterxml.jackson.core not found, required by com.fasterxml.jackson.module.paramnames
    at java.base/java.lang.module.Resolver.findFail(Resolver.java:893)
    at java.base/java.lang.module.Resolver.resolve(Resolver.java:192)
    at java.base/java.lang.module.Resolver.resolve(Resolver.java:141)
    at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:492)
    at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.ModuleLayerHandler.buildLayer(ModuleLayerHandler.java:75)
    at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.TransformationServicesHandler.buildTransformingClassLoader(TransformationServicesHandler.java:60)
    at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.Launcher.run(Launcher.java:106)
    at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.Launcher.main(Launcher.java:78)
    at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26)
    at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23)
    at cpw.mods.bootstraplauncher@1.1.2/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141)

Mod Used

• gml-4.0.9-all.jar
• create-1.20.1-0.5.1.f.jar
• valkyrienskies-120-2.1.3-beta.1.jar
• create_interactive-1201-forge-1.0.2-beta.1.jar

[lukebemish]

This appears to be due to us moving Jackson to a LIBRARY while the one Valkyrien Skies includes gets it's stuff shoved on GAMELIBRARY. We're looking into solutions, though this is not an easy one to solve

[lukebemish]

This should be fixed on neoforge 1.20.5 once we get this released for that version; I will be looking into fixes for older versions, but unfortunately there's not much we can do there in a clean way.

[mikedrugs]

getting the same crash

[lukebemish]

This should not be an issue on the neoforge 1.21 release of GML; there is nothing that we can do to fix this on mcforge 1.20.1 unless mcforge themselves fix it. They've recently made a change to the jarJar system on a newer version -- which it appears they're backporting? -- that will load jarJar-ed libraries on the layer of their parent (that is, the ones we bundle would be loaded as LIBRARY not GAMELIBRARY). However, this does not actually fix the issue -- we need the ones Valkyrien Skies bundles to be loaded as LIBRARY even if Valkyrien Skies is itself a mod that loads on the game layer, and bundles a newer version. Having watched attempts to change the behavior necessary to fix this with the mcforge folks fall through, and having inspected how everything gets loaded, there does not appear to be any solution to this in 1.20.1, even a fairly hacky one. We could probably do some Unsafe schenanigans to move around modues after the fact, but, frankly, that sounds like a Bad Idea on so many levels. Valkyrien Skies could fix this on their end by manually marking the relevant libraries, and anything that provides services they load, as FMLModType: LIBRARY, though really the system ought to be designed to not require that level of work from an unrelated mod. I will leave this issue open, but at present I do not forsee this being fixed on our end in 1.20.1.