Group4Layers / ex_image_info

ExImageInfo is an Elixir library to parse images (binaries) and get the dimensions (size), detected mime-type and overall validity for a set of image formats. It is the fastest and supports multiple formats.
https://hex.pm/packages/ex_image_info
Other
95 stars 4 forks source link

Adds github workflow ci action #5

Closed warmwaffles closed 11 months ago

warmwaffles commented 11 months ago

This is to replace Travis.

I'm working on another branch to modernize this up to latest Elixir and OTP

warmwaffles commented 11 months ago

I think supporting the latest 3 versions of OTP and elixir are preferable. As anything beyond is unsupported by upstream erlang and elixir doesn't push updates for older versions.

rNoz commented 11 months ago

Good one! Thanks!

warmwaffles commented 11 months ago

I need #7 to land before this one does. There's some funkyness with credo.

rNoz commented 11 months ago

Other PRs are squashed+merged.

Some of these CI tasks are failing due to a nested dependency (JSX).

warmwaffles commented 11 months ago

Awesome, rebased and now just the linter fails. Will get that rectified.

warmwaffles commented 11 months ago

@rNoz linter fixed and now everything passes.

EDIT: I also agree with the squash merge philosophy for libraries. Keeps the history nice and linear.