search

Growlith1223 / ArsMagica2

Ars Magica 2 Bug Tracker
65 stars 31 forks source link

Fix Randomteleport,Disarm,ManaBattery 1.10.2 #120

Closed Orinion closed 7 years ago

Orinion commented 7 years ago

Fixed Randomteleport doing nothing.#91 However, the randomLocation is still likely to be in the ground, resulting in not teleporting. Also Fixed #58 You might want to increase the PickupDelay.

ProfHugo commented 7 years ago

With 1.9 adding the ability to carry items in offhand, would it be nice if disarm also drop held items in offhand aswell?

Orinion commented 7 years ago

Fixed #117

Orinion commented 7 years ago

Yeah, maybe when combined with a power modifier

ProfHugo commented 7 years ago

Just wondering, in line 54 and 55:

if (target instanceof EntityPlayer && ((EntityPlayer)target).getActiveItemStack() != null && !target.worldObj.isRemote){
            if (EnchantmentHelper.getEnchantmentLevel(AMEnchantments.soulbound, ((EntityPlayer)target).getActiveItemStack()) > 0)
                return true;
            ((EntityPlayer)target).dropItem(true);
            return true;
        }

getActiveItemStack is still used with soulbound check, and if it were to be true that this method is deprecated, then wouldn't this also cease to work?