Growlith1223 / ArsMagica2

Ars Magica 2 Bug Tracker
65 stars 31 forks source link

[1.5.0-15] Summon Spell does not obey the type of crystal phylactery thrown in during spell creation #161

Open kingofrunes opened 7 years ago

kingofrunes commented 7 years ago

Found another spell bug.

1.5.0-15 Ars Magica Forge 12.18.3.2815

Made a simple projectile summon spell with Dryad Crystal Phylactery filled to 100% but upon spell creation and use it just summons skeletons.

Here is the NBT data to show it properly has the Dryad set in it's spell data summon_dryad_nbt

Upon further investigation it looks to be an issue in SpellUtils.java getSpellMetadata function. Due to the SummonType being nested behind 2 am2 tags when it was only expecting it to be behind one it's causing that to always return blank. So either the NBT data needs to be fixed upon spell creation or the getSpellMetadata needs to be adjusted to account for that.

On another note about the summoning spell. I noticed that somehow my summon counts didn't get updated. I can no longer cast the summon spell. Needs to have a way to reset it or a better way to track that.

Growlith1223 commented 7 years ago

i'll look into it, thanks! and regarding the summon system, i have plans to further improve/revamp it so don't worry about that, but thanks for telling me anyway!

EnderMelody commented 6 years ago

Im having this problem still in 1.10.2 latest version (1.5.0-18) and I was wondering if you were working on a fix for this