Growlith1223 / ArsMagica2

Ars Magica 2 Bug Tracker
65 stars 31 forks source link

[1.5.0-17] Massive FPS Loss With Placed Inscription Table #178

Open MokahTGS opened 7 years ago

MokahTGS commented 7 years ago

Getting a huge FPS loss when I place the Inscription Table down.

Before: https://dl.dropboxusercontent.com/u/9882100/Minecraft/2017-02-05_13.27.43.png

After: https://dl.dropboxusercontent.com/u/9882100/Minecraft/2017-02-05_13.27.55.png

72 FPS down to 8 FPS

Growlith1223 commented 7 years ago

90% of the blocks in the mod are causing fps issues, im aware of this

Da-Technomancer commented 7 years ago

After a quick look through some of the tile entities, I can see why there would be FPS issues. Mainly from the fact that 90% of the tile entities call worldObj.markAndNotifyBlock(pos, worldObj.getChunkFromBlockCoords(pos), worldObj.getBlockState(pos), worldObj.getBlockState(pos), 3); every tick on both the server and client side in onUpdate(). This is really bad. They should only be calling it if there is a good reason, not every tick no matter what.

Growlith1223 commented 7 years ago

im aware of that, just haven't gotten around to fixing it yet lol, but yea, it makes sense

lordchubz commented 7 years ago

I was having this issue until I removed BetterFPS from my modpack.

HeavyDeception commented 7 years ago

This happens with every block form AM2 for me. but I see you know what it is. will wait for an update.

MokahTGS commented 7 years ago

So still getting a bit of FPS drop with placed blocks from the mod. Weirdly enough the inscription table is not one of them. Things have improved but there is still issues with some of the placed normal blocks.

TheIcyOne commented 7 years ago

Inscription table should still be one of them, the mod hasn't updated.

MokahTGS commented 7 years ago

That's really odd. Putting the inscription table down does nothing to the frame rate. Putting the oculus down has a small blip and some of the other tables make a bigger drop in FPS.

TheIcyOne commented 7 years ago

It'll depend which chunk you place it in, if you have a lot of complex models in the chunk it will slow things down quite a bit.

MokahTGS commented 7 years ago

Ahh...I was secretly hoping this got stealth fixed.