search

Growlith1223 / ArsMagica2

Ars Magica 2 Bug Tracker
65 stars 31 forks source link

Mage armor takes durability damage when using a Blood Magic 2 Sacrificial Dagger #195

Open xenxero1 opened 7 years ago

xenxero1 commented 7 years ago

Origionally posted this on the Blood Magic issues list. https://github.com/WayofTime/BloodMagic/issues/1043#issuecomment-277832623

Essentially, when wearing Mage Armor and self-sacrificing on a blood altar, the mage armor takes durability damage.

Growlith1223 commented 7 years ago

interesting mod interaction lol, i'll take a look thanks!

TheIcyOne commented 7 years ago

Result of this in am2.armor.AMArmor: else /*Will include custom damage types and void, wither etc. */{ stack.damageItem(damage * 10, entity) Since the dagger uses a custom damage type (DamageSourceBloodMagic), this will need to be specifically supported through the use of the Blood Magic API.

TheIcyOne commented 7 years ago

Now fixed, @xenxero1?

xenxero1 commented 7 years ago

Is there a way to access this branch without a release? I've been using the releases on curseforge strictly.

TheIcyOne commented 7 years ago

There is, but it's a little awkward. You'd have to either fork the repo or grab it as a zip from https://github.com/Growlith1223/ArsMagica2/archive/1.10.2.zip and run "gradlew.bat build" from the directory, which should create an arsmagica2[version].jar in the build folder.

If that doesn't work, I've probably forgotten a step.