Growlith1223 / ArsMagica2

Ars Magica 2 Bug Tracker
65 stars 32 forks source link

1.10.2 Ars Magica 2 Soulbound duplicates items #263

Open djoveryde opened 7 years ago

djoveryde commented 7 years ago

If a player dies their soulbound items (ie pick) will duplicate. Can't seem to disable soulbound or figure a way to fix the issue.

I am running latest forge with sponge

It happens also when travelling between the End and Overworld via portal. I'm assuming it has to do with the end portal putting you at respawn, something about simulating a death while keeping your items. What's concerning is that is reset my Arcane Spellbook's contents to a point a day before. I've been unable to find any significance to that point it reset me to, other than spells I had given away had appeared once more, and some higher tier spells I made were gone.

xenxero1 commented 7 years ago

It should be noted the last paragraph occured using DrCyano's Lootable Bodies, and on a default forge server without sponge.

TheIcyOne commented 7 years ago

Where are the items duplicated to? Soulbound should try to place the items in their original slots.

djoveryde commented 7 years ago

I was using a plugin called graves which added the item in the grave duplicating it as well as you keeping it in the set slot.

LemADEC commented 7 years ago

@djoveryde can you reproduce without Sponge?

TheIcyOne commented 7 years ago

I've been unable to reproduce this myself even with Sponge, so the config option acts as a temporary solution.

djoveryde commented 7 years ago

Issue doesn't reproduce for me on forge alone. It seems the issue is worse when you have a mod like graves installed with sponge. Not sure if that can reproduce the issue or not unless sponge has released a newer version which fixes the bug perhaps?

bookerthegeek commented 7 years ago

So sponge and spulbound and another grave style mod?

xenxero1 commented 7 years ago

I can reproduce it without sponge. Using the spinycraft V2 pack. Only grave type mod installed is Dr Cyano's lootable bodies. Sponge is NOT required.

bookerthegeek commented 7 years ago

@xenxero1 thank you, saved me a bunch of testing.

TheIcyOne commented 7 years ago

The current issue appears to be that the Lootable Bodies mod uses the LivingDropsEvent rather than the LivingDeathEvent used by AM2, theoretical fix could be to remove the soulbound items from the LivingDropsEvent list too, although that will need testing.

LemADEC commented 7 years ago

Sounds like a bug in Lootable Bodies more than an AM2 one

TheIcyOne commented 7 years ago

Perhaps, but it is an issue with multiple mods from what I can tell, and it should be solvable on AM2's end anyway.

xenxero1 commented 7 years ago

Its an issue with the way mods interact. Either side could potentially solve it. I know Advent of Ascensions soulbound system works with lootable bodies... wonderfully in fact!