Growlith1223 / ArsMagica2

Ars Magica 2 Bug Tracker
65 stars 31 forks source link

Networking cleanup & some feature re-enable #391

Open jjtParadox opened 7 years ago

jjtParadox commented 7 years ago

Alright this one's a big one. I found that a lot of packet sending and handling code hadn't been ported from 1.7.10, leaving a lot of functionality simply not working. I swept things up by commenting out stuff that wasn't being handled or used and uncommented stuff that could be handled. Here's the list of affected features:

I also removed (commented out) packet IDs that were either never used or not handled. Here's the list of unused packets:

Multiple of the above packets were temporarily deprecated in favor of the SYNC_CLIENT packet or networking methods provided by Forge (i.e. I found that the RUNE_BAG_GUI_OPEN packet had been superseded by Forge's FMLNetworkHandler). However, some of the above likely represent non-existent features that are missing in the current 1.10.2 version. These should be looked into and updated if possible.

Additionally, PR #364 removes the SYNC_CLIENT packet and replaces it with some of the above packets. If that PR is merged in, this PR will need to update to resolve the merge conflict.

I temporarily disabled beta tester aura sync, as the AM2 extended properties do not have data storage for the aura. That'll be in a future PR.

(Also, an "Is player flipped" packet is being sent to every player on every game player tick. Is that optimal?)

EdwinMindcraft commented 7 years ago

Neither the flip nor the shrink feature should be enabled ideally : They're both unstable and not exactly working.