search

GrowthcraftCE / Growthcraft-1.12

Growthcraft is a low-tech brewing, farming, and cooking Minecraft Mod.
GNU Affero General Public License v3.0
33 stars 22 forks source link

Crashes not fixed with 4.2.2 #358

Closed xJon closed 3 years ago

xJon commented 3 years ago

Game crashed upon breaking grape plant with the new version. Report: https://pastebin.com/MHQVdMNu

Alatyami commented 3 years ago

Single player or multi player. Just tested and I'm not able to reproduce it with 4.2.2

xJon commented 3 years ago

Single player. As you can see from the crash log I'm using 4.2.2.

Alatyami commented 3 years ago

Just had to double check. We had one report previously that the client had the newer version but not the server.

clienthax commented 3 years ago

@Alatyami manifest is missing the AccessTransformer entry, so it is never applied in production, resulting in these problems.

clienthax commented 3 years ago

https://github.com/GrowthcraftCE/Growthcraft-1.12/pull/359

Alatyami commented 3 years ago

Doh, must have happen during the refactoring to get it to build again. Thanks!

clienthax commented 3 years ago

You can likely revert the previous fix too, as it just does an additional block lookup.

Alatyami commented 3 years ago

Uploaded to curse forge, will be available once the file is approved.