GrowthcraftCE / Growthcraft-1.12

Growthcraft is a low-tech brewing, farming, and cooking Minecraft Mod.
GNU Affero General Public License v3.0
33 stars 22 forks source link

Unable to create Sake/Rice Water. #380

Closed TonyArcane closed 1 year ago

TonyArcane commented 2 years ago

2022-03-16_17 52 06 Sake/rice water doesn't seem to be working correctly. Also side note there is no recipe for cooked rice. Not sure about it but I am using the latest version available on the overwolf/twitch launcher. Please let me know if this is a bug that I have found or if it is a duplicate?### ###

Alatyami commented 2 years ago

We haven't implemented Growthcraft Rice yet, except for a handful of the items. Once we finish up Growthcraft Milk, Rice is the last to be completed. We'll use this ticket to track the progress.

TonyArcane commented 2 years ago

Thank you, Also Just saying some JEI integration would be lovely as looking through the wiki all the time when trying to re learn the mod cause I used to play the OG mod and some things here are the same yet different.

Alatyami commented 2 years ago

TonyArcane .... is this issue intended for Growthcraft for Minecraft 1.12 or 1.16?

gatoborrachon commented 2 years ago

+the water texture on the pic he provided seems to be 1.13+ (or maybe it is too stretched?), but the textures of the blocks are from 1.12-

+I will test this thing right now since i have the oportunity, give me a moment -(but yeah, 1.12 JEI support would be neat, but i also know that the recipe system of Growthcraft 1.12 is fundamentally incompatible with JEI, that would require a rewrite and i know that 1.12 is bug-fixes only, no problem)

TonyArcane commented 2 years ago

Gatoborrachon is correct this is 1.12.2 to be specific though I guess I could be missing something though this isn't this only issue I have ran into as of recent. For what ever reason none of the Milk liquids can't be fermented into kumis.

gatoborrachon commented 2 years ago

are you using OpenJ9?

TonyArcane commented 2 years ago

Openj9? I am using the latest version of java that is all I know.

gatoborrachon commented 2 years ago

ok, that's fine

Have you added the Brew Kettle Lid to the Brew Kettle?

My bad, by the pic you shared, you haven't added the Lid to the Brew Kettle, it's necessary to process the Rice

gatoborrachon commented 2 years ago

Also @Alatyami, regarding to the JEI compat, i don't want to be a pain in the rear, but in case you are interested in adding it despite the difficult of the issue, i could recommend you to ask here: https://cleanroommc.com/

It's a group of modders focused in 1.12 modding/modpack making, but they use JEI a lot (they even have a fork: HEI), so i can only think that there's no better place to ask about 1.12 JEI compat than there

TonyArcane commented 2 years ago

Yeah seems that way like I said before I am way more used to the old way of making Sake so this is my fuck up that and it doesn't help that there is no in game way to know I need the brew kettle lid. You used to be able to put rice straight in and young sake was made and put rice in the furnace to get cooked rice.

gatoborrachon commented 2 years ago

Well, we will always have the wiki: https://github.com/GrowthcraftCE/Growthcraft-1.12/wiki/Growthcraft-Rice

But yeah, it isn't so practical when you are in-game, maybe a book like Patchouli or Guidebook could help, if not, there could be at least some advices in the Information JEI tab

TonyArcane commented 2 years ago

Very much so, I agree with that. though I have a small question, Is there a compatibility issue with other mods that add a milk liquid cause I can't seem to ferment milk into Kumis and I am thinking that Tinkers Construct may be the issue.

gatoborrachon commented 2 years ago

Well, i honestly have no idea, the wiki doesn't say anything about it more than what it is, i don't even knew about its existence until now, but you could test it and tell us what happened (removing TCon temporally)

Alatyami commented 2 years ago

Because this is for 1.12 ..... have you deleted your recipe configs and let them rebuild?

The old way that we implemented the mod made it very difficult to do JEI compatibility. We tried it a couple of times.

Growthcraft for 1.16+ has JEI integration.

TonyArcane commented 2 years ago

Because this is for 1.12 ..... have you deleted your recipe configs and let them rebuild?

The old way that we implemented the mod made it very difficult to do JEI compatibility. We tried it a couple of times.

Growthcraft for 1.16+ has JEI integration.

No this is for a premade pack that I am helping with play testing. That issue has come up and talked to the pack dev about it. The only recipes that showed were crafting table and furnace recipes and nothing else.

Well, i honestly have no idea, the wiki doesn't say anything about it more than what it is, i don't even knew about its existence until now, but you could test it and tell us what happened (removing TCon temporally)

I will give it a try but we will see what happens

TonyArcane commented 2 years ago

Well, i honestly have no idea, the wiki doesn't say anything about it more than what it is, i don't even knew about its existence until now, but you could test it and tell us what happened (removing TCon temporally)

So I just finished the test and turns out Milk isn't fermentable and it seems like Kumis is just not able to be made in the 1.12 version.