search

GrowthcraftCE / Growthcraft-1.20

Growthcraft is a collection of Minecraft mods that adds an extra layer of immersion into the world of Minecraft.
Other
0 stars 5 forks source link

Cellar config issues #100

Closed moonfather1 closed 3 months ago

moonfather1 commented 4 months ago

cellar currently has 6 configurable values. all 6 are unused.

( no one gasps in surprise )

also HopsCropBlock demonstrates a bad way to use a config value.

Alatyami commented 4 months ago

Both are tech debt that is no longer used.

Alatyami commented 4 months ago

For cellar the recipe files replaced all of the brew kettle settings.

Alatyami commented 4 months ago

Running tests now.

moonfather1 commented 4 months ago

don't kill the config class, i added a few things to it today.

Alatyami commented 4 months ago

I flagged as deprecated. Want to remove all the config items that are no longer needed in your PR?

moonfather1 commented 4 months ago

not sure... kettle ticks is obsolete by recipes (though we could add a multiplier with a default of 1.0), others no so much...

four are drop counts for hops and grapes and can be easily rewired.

one is some light level, we could return that if make the lid part of the kettle block state. someone super-over-complicated it with separate item. but let's leave that for another day.

up to you.

Alatyami commented 3 months ago

Want to keep the lid as that is part of the "process" for boiling vs steaming.

Drops should shift to loot tables.

Alatyami commented 3 months ago

Drops are now in the loot table.

Alatyami commented 3 months ago

Added deprecation for GrowthcraftAppleConfig, GrowthcraftBambooConfig and GrowthcraftRiceConfig.

Alatyami commented 3 months ago

Done