search

GrowthcraftCE / Growthcraft-1.20

Growthcraft is a collection of Minecraft mods that adds an extra layer of immersion into the world of Minecraft.
Other
0 stars 5 forks source link

refactor GC modules in proper sub-modules #148

Closed Hojosa closed 3 weeks ago

Hojosa commented 1 month ago

full refactor of our modules, heavily based of how enderio & project red are doing thier sub modules. this initial PR is mostly for review and getting feedback on the structure

notes: run configs havent been tried yet, wont work most likely building doesnt work yet, needs to be done via jarjar, so we still have a single .jar file mod dependencies for testing need to be resturctured. sonar is also not enabled yet. switched to neoforge 1.20.1. had some issues with forge gradle to get this to work. may work with forge&forge gradle, has to be tested

in my setup, the core module is wrongly displayed as "Growthcraft-1.20-core". dont know what i did wrong here, or if its maybe just some local thing. would be happy about feedback from someone, how this is looking on thier dev setup

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud