GrowthcraftCE / Growthcraft-1.7

Community Edition of Gwafu's Growthcraft Mod
Other
39 stars 29 forks source link

Fishtrap and Harvestcraft [1.11] #443

Closed Kisutora closed 7 years ago

Kisutora commented 7 years ago

As Growthcraft 1.11 Alpha 3.0.0.1 came out I decided to leave a few fishtraps underwater while I went to have some breakfast and when I got back to it these were the results: sample 1 sample 2 As you can see with Harvestcraft installed the Fishtraps fill up very quickly if you're going the manual route. This overflow of fish can be dealt with by building an automatic hopper chest systemautomatic farm so I thought I'd just let you know that this is a thing and it could possibly be annoying for players that don't want an automatic fish farm and have Harvestcraft installed. For me however and probably for most players you'll be building an automatic farm anyways so I don't see this as a problem. What is a problem however is Harvestcraft fish going into the item slot reserved for rotten flesh. Thanks!

P.S. The fishtrap appears transparent when you hold the block in your hand but when you place it it's not transparent. fishtrap transparency manual farm

Alatyami commented 7 years ago

Are you able to report issues via the Growthcraft 1.11 repo? https://github.com/GrowthcraftCE/Growthcraft-1.11/issues

The bait issue is known, that is the last major item to finish.

Transparency when placed in the world ... when the texture render the back doesn't render and it looks bad. this was also the case with 1.7

The overflow, is an interesting observation. The new Fishtrap actually acts more like a hopper. If you do not add the hoppers it will fill the inventory slots up to "6" anything beyond that will be ditched. Because you added hoppers, it looks like it gives the overflow somewhere to go. That is not intended behavior. The LootTable is built from the same loot table as the Fishing Rod, so getting the Harvestcraft fish makes sense and would be intended. In the future, we'll add a filter mechanism via a config file.

I have plans on having the Fishtrap, Gold Fishtrap, and Diamond Fishtrap with additional inventory slots. But that would be for 3.1.0. Currently the plan is to port everything over and then add features.

Kisutora commented 7 years ago

Great! Glad I could be of any help. I'll post this over to the right place now ;)