Pies with command names

[pgilfernandez]

Very cool your implementation! it looks so promising. The core work is done, I really like it! I have some comments to make them more robust and prettier:

Allowance

Now you are allowing them only in circular but the would fit in Rainbow and "left and right" types: This would be a just icons option:

Then you can add names in the outer direction:

This technique also works with Rainbow pies:

Items arrangement in circle pies

As the feature is already there (and working so nicely), I would say we just need to work a little bit more in the display/layout maths. If this is a normal pie with 8 icons:

This is the pie with command names activated:

And this is the real example:

As you see, they get need more spacing between them. In a first approach this would be what I suggest: 1) Vertical spacing so that the names have space to not overlap vertically:

2) Then adding some maths to that top and bottom items get nicely aligned:

3) at that point you will see that the "circle" arranging gets lost (because of the manual vertical alignment):

4) so that we would need to arrange them back in the following way:

If you can add maths to that arrangement it would be awesome.

[pgilfernandez]

I would like to let you know that I'm working on command names for LeftRight pie shape, just in case you haven't started working on it ;) this one:

[pgilfernandez]

I would like to let you know that I'm working on command names for LeftRight pie shape, just in case you haven't started working on it ;) this one:

This feature has already been merged 7cc7920e0344667239dcbb7099a8588003acd40e =)

[Grubuntu]

I modified the Pie shape with the commands activated for better spacing management:

it's in development version 139 to test: https://github.com/Grubuntu/PieMenu/tree/next-dev139

[pgilfernandez]

It looks like we've been working on the same feature in parallel, hehehe. I feel like my algorithm has a better layout but it still doesn't work properly depending on the number of commands:

So, if you don't mind, I'm gonna try to modify your layout to match mine. I have now a spare hour, let's see if it's enough to finish it ;)

[Grubuntu]

So, if you don't mind, I'm gonna try to modify your layout to match mine. I have now a spare hour, let's see if it's enough to finish it ;)

Of course. My layout is not ideal, I hope you can improve it. THANKS

[pgilfernandez]

I've PR the branch with my proposal for X distribution: https://github.com/Grubuntu/PieMenu/pull/47

Your Y one is different to mine as mine adds a spacing between icons, would you mind to include it as you know better your algorithm than me? I used a spacing of buttonSize * 1.2 in case you want to use that one.

BTW, our both approaches were pretty similar in concept but your implementation is much better (that's why mine wasn't still working with any number of icons...)

[Grubuntu]

Your algorithm is more beautiful than mine. I failed miserably with trigonometry ;)

I used a spacing of buttonSize * 1.2 in case you want to use that one.

I fixed minimum Y spacing in this commit : https://github.com/Grubuntu/PieMenu/commit/14f136b20166563c3804c50c2e062d2577583d5a

[pgilfernandez]

It looks great! Good team work, hehehe.

Tomorrow or this weekend I would like to fine tune the stylesheets and make the new CommandNames styleable, let me PR it to the new-139 branch, ok?

[Grubuntu]

Of course.