search

Grumbel / sdl-jstest

Simple SDL joystick test application for the console
GNU General Public License v3.0
55 stars 31 forks source link

BUILD_TESTS does nothing #20

Open orbea opened 8 months ago

orbea commented 8 months ago

In commit https://github.com/Grumbel/sdl-jstest/commit/5bc418e7f12b6da24992b414d1e06ce424d30e5c the appdata files were removed, but the BUILD_TESTS cmake option remained.

https://github.com/Grumbel/sdl-jstest/blob/a73cfcbd95ec3fb62e65340f1e3ec43648e50491/CMakeLists.txt#L52-L55

It now does nothing since the appdata files are gone, what was the intent here? Are different tests going to be created in the future? Should BUILD_TESTS be removed altogether? Should the appdata files be restored? I don't have a personal preference here.

orbea commented 7 months ago

@Grumbel I would really appreciate your input here.

Apteryks commented 1 week ago

Indeed, I also get: "No tests were found!!!" when running 'make check'.