GrumpyOldPizza / ArduinoCore-stm32l0

Arduino Core for STM32L0
125 stars 67 forks source link

Private members in CayenneLPP #68

Open MartinNel opened 5 years ago

MartinNel commented 5 years ago

In our application we want to extend the CayenneLPP class, therefore we derived a class from the CayenneLPP class. However this derived class cannot access the common variables like buffer, maxsize and cursor in the CayenneLPP class since these are private members.

Can you change these member variables in the CayenneLPP class to be of type protected, this way derived classes can access these member variables.

Martin

GrumpyOldPizza commented 5 years ago

Martin, send me an e-mail (no pull request) to grumpoldpizza@gmail.com

I do not like the CayenneLPP class as is either. IMHO it should be layered directly onto the LoRaWAN class, so that the TX buffer can be reused. To be honest, I just took it from the archieves and made it compile.

Hence it would be interesting to see what your needs are, so that this could be addressed in a sane way.