search

GrumpyOldTroll / libmcrx

Multicast receive library.
Other
5 stars 2 forks source link

Removing unused headers and functions #19

Open ghenry opened 2 years ago

ghenry commented 2 years ago

Some of these includes can be deleted, but I'm presuming the unused functions are for users of the library?

Screenshot from 2022-02-03 12-20-19

We could clear these warnings by using them in a test cases if possible.

GrumpyOldTroll commented 2 years ago

Yes, test cases that use these is I think the right action for those functions.

Was there a file for the unused includes? Pretty sure those are needed in some cases, but I believe it if it's saying they're present in some places they're not needed.

ghenry commented 2 years ago

Things like cppcheck and clang-tidy find these which CLion uses:

https://www.jetbrains.com/help/clion/code-inspection.html https://www.jetbrains.com/clion/features/code-analysis.html