Closed GrumpyOldTroll closed 2 years ago
PS: note that building this also requires integrating https://github.com/GrumpyOldTroll/chromium/pull/1
Yes, sorry about that, thanks for pointing it out. It now actually stores it in the config as well. I pushed it to your branch and tested with config.HasClientSentMulticastParameters(perspective) and it worked now.
Also ran server and client and the frames worked fine, so PR LGTM!
@MaxF12, I merged but at the bottom of QuicSession::OnConfigNegotiated the config_'s multicast_clientparams seems empty if I call QuicConfig::HasClientSentMulticastParameters.
Do you know where it's supposed to get parsed into the server's config, and is that part implemented? It looks like it's only set from SetMulticastParams and FillMulticastParams, but should it also be filled by parsing in QuicConfig::ProcessTransportParameters?