search

GrumpyOldTroll / quiche

BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

initial implementation of control frames (part of issue #5) #11

Closed GrumpyOldTroll closed 2 years ago

GrumpyOldTroll commented 2 years ago

@MaxF12, I merged but at the bottom of QuicSession::OnConfigNegotiated the config_'s multicast_clientparams seems empty if I call QuicConfig::HasClientSentMulticastParameters.

Do you know where it's supposed to get parsed into the server's config, and is that part implemented? It looks like it's only set from SetMulticastParams and FillMulticastParams, but should it also be filled by parsing in QuicConfig::ProcessTransportParameters?

GrumpyOldTroll commented 2 years ago

PS: note that building this also requires integrating https://github.com/GrumpyOldTroll/chromium/pull/1

MaxF12 commented 2 years ago

Yes, sorry about that, thanks for pointing it out. It now actually stores it in the config as well. I pushed it to your branch and tested with config.HasClientSentMulticastParameters(perspective) and it worked now.

MaxF12 commented 2 years ago

Also ran server and client and the frames worked fine, so PR LGTM!