A few Reporter Fixes - Githubissues

GruntBlanketMocha / grunt-blanket-mocha

Headless Blanket.js code coverage and Mocha testing via PhantomJS

MIT License

53 stars 37 forks source link

A few Reporter Fixes #10

Closed philschatz closed 10 years ago

philschatz commented 10 years ago

I'm not sure if these are still necessary but this Pull Request:

adds _$blanket to the ignored globals list
calls originalReporter with the correct this
adds suiteURL and testURL methods which are expected by HTMLReporter

These were added to get tests working on https://github.com/philschatz/css-coverage.js and https://github.com/philschatz/octokit.js

geekdave commented 10 years ago

Thanks, @philschatz ! The CSS coverage project looks really useful... going to give it a try. :)

englercj commented 10 years ago

I think this was supposed to be originalReporter.apply(originalReporter, [runner]) since this is actually window and causes an error. I have to use v0.3.2 because v0.3.3 is broken right now.

geekdave commented 10 years ago

Hmm, thanks for reporting, @englercj

@philschatz : Would originalReporter.apply(originalReporter, [runner]) work for your case as well?

philschatz commented 10 years ago

yep, @geekdave! I believe that would have worked as well.