GruntBlanketMocha / grunt-blanket-mocha

Headless Blanket.js code coverage and Mocha testing via PhantomJS
MIT License
53 stars 37 forks source link

3rd Party Integration w/ Codecov #32

Open stevepeak opened 10 years ago

stevepeak commented 10 years ago

I'm interested in directly integrating Codecov.io into this project. I would love to chat and help out in any way to make this possible. I could contribute the methods if you would accept a PR or our upload guide can be found there.

Have a great week and enjoy the great outdoors!

geekdave commented 10 years ago

Hi @stevepeak - I'd prefer not to have any tight-coupling with any 3rd party services baked directly into this project. But if you'd be open to submitting a PR that enabled generic integration points, such that Codecov could be a separately-hosted "plugin" for grunt-blanket-mocha, I would be open to that. Thanks!

stevepeak commented 10 years ago

Thanks Dave! As far the generic integration: would you accept a method that would simply take a url to post the result too? I'm trying to make this as easy as possible for people to use to create more awareness of the benefits of code coverage and utilize our great features.

geekdave commented 10 years ago

Sounds like a good possibility. What structure would the data have? Could you provide an example?

On Sun, Nov 9, 2014 at 3:44 PM, Steve Peak notifications@github.com wrote:

Thanks Dave! As far the generic integration: would you accept a method that would simply take a url to post the result too? I'm trying to make this as easy as possible for people to use to create more awareness of the benefits of code coverage and utilize our great features.

Reply to this email directly or view it on GitHub https://github.com/ModelN/grunt-blanket-mocha/issues/32#issuecomment-62323535 .

stevepeak commented 10 years ago

Uploader accepts lcov, gcov, xml, json https://codecov.io/api I can also add more if necessary.

geekdave commented 10 years ago

Sounds good to me - PR would be welcome!

On Sun, Nov 9, 2014 at 3:54 PM, Steve Peak notifications@github.com wrote:

Uploader accepts lcov, gcov, xml, json https://codecov.io/api I can also add more if necessary.

Reply to this email directly or view it on GitHub https://github.com/ModelN/grunt-blanket-mocha/issues/32#issuecomment-62323958 .