Gruntfuggly / activitusbar

A VSCode extension to save some real estate by recreating the activity bar buttons on the status bar
Other
114 stars 15 forks source link

Terminal icon doesn't work #38

Closed yume-chan closed 3 years ago

yume-chan commented 3 years ago

I added an icon for terminal in settings.json

"activitusbar.views": [
    {
      "name": "terminal",
    }
  ]

Click it once does nothing, and click it twice toggles sidebar.

I also see errors in DevTools:

image

Looking at keybindings.json, the command name should be workbench.action.terminal.focus or terminal.focus

Code Version:

Version: 1.52.0-insider (user setup)
Commit: 92192baf760315ac47fb2caaf3ce6d0778962352
Date: 2020-12-03T05:43:59.635Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.17763
Gruntfuggly commented 3 years ago

Yes, you're right. Maybe the API changed. You can make it work for now, by using

        {
            "name": "command.workbench.action.terminal.focus",
            "codicon": "terminal"
        }

I'll fix it properly in the next release.

yume-chan commented 3 years ago

That works, thanks!

I will leave this issue open and let you close it after fixed.

Gruntfuggly commented 3 years ago

Should be fixed in 0.0.37

yume-chan commented 3 years ago

Fix verified.