Wrong icon size/weight when set manually

Gruntfuggly / todo-tree

Use ripgrep to find TODO tags and display the results in a tree view

Other

1.42k stars 136 forks source link

Wrong icon size/weight when set manually #486

Closed Gliptal closed 3 years ago

Gliptal commented 3 years ago

The default icons the extension provides are crisp-looking and fit nicely in the available space:

Code_Mg3MehdJG4

Setting that same icon ("icon": "check-circle", for example) results in a larger (or weightier) icon that feels blurrier and doesn't entirely fit in the available space (notice the lower portion of the circle is cut).

Code_uB6hiVGlhp

The same behaviour can be seen in the gutter.

Gruntfuggly commented 3 years ago

The check-circle icon is from the codicons (or octicons), and is provided by vscode, so I have no control over it unfortunately. The default is an old SVG I found a long time ago.

Gliptal commented 3 years ago

Ah I was under the impression they were the same icon, just loaded differently. Thanks for the quick explanation!