search

Gruntfuggly / todo-tree

Use ripgrep to find TODO tags and display the results in a tree view
Other
1.42k stars 137 forks source link

Relative paths in `includeGlobs` don't work #566

Open OldStarchy opened 2 years ago

OldStarchy commented 2 years ago

I have a project structure like so

/app (workspace root)
    /app
    /node_modules
    /vendor
    ...other stuff

With the following config

    "todo-tree.filtering.includeGlobs": [
        "app/**"
    ]

No TODO's appear in the list.

Using app shows no results
Using app/** shows no results
Using app/**.* shows no results
Using ./app/** shows no results
Using **/app/** shows all TODO's in the workspace since it matches /app
Using /app/app/** does what I want, but absolute paths don't work in all workspaces

Gruntfuggly commented 2 years ago

Yes, unfortunately include and exclude glob paths are absolute. You could define the includes globs in the workspace settings?

OldStarchy commented 2 years ago

Yeah, I could, but nearly all of the projects I work on have the same project structure, differing only in the project's root path.

Any chance of supporting "${workspaceRoot}/app/**"?

Gruntfuggly commented 2 years ago

There may be some issues with workspaces, but I'll give it a go.