Gruntfuggly / todo-tree

Use ripgrep to find TODO tags and display the results in a tree view
Other
1.45k stars 142 forks source link

Markdown checkboxes no longer working #577

Closed mhkeller closed 2 years ago

mhkeller commented 2 years ago

This plugin used to find things like

- [ ] this line was highlighted as a todo
- [x] this was already done and was not picked up 

For example it shows up in this person's issue as working correctly https://github.com/Gruntfuggly/todo-tree/issues/256

I'm using version 0.0.214 and these are no longer being detected. Is this a bug or did something change in the regex?

Gruntfuggly commented 2 years ago

Can you post your todo tree settings?

mhkeller commented 2 years ago
{
  "todo-tree.highlights.defaultHighlight": {
        "foreground": "#fff",
        "background": "#00a1ff",
        "iconColour": "#00a1ff",
    },
  "todo-tree.tree.hideTreeWhenEmpty": true,
  "todo-tree.filtering.excludeGlobs": [
        "**/node_modules",
        "**/site-packages",
        "**/env",
        "**/venv"
    ],
  "todo-tree.filtering.ignoreGitSubmodules": true,
    "todo-tree.tree.flat": true,
    "todo-tree.highlights.highlightDelay": 133,
    "todo-tree.general.statusBar": "total",
    "todo-tree.general.debug": true,
    "todo-tree.general.tags": [
        "BUG",
        "HACK",
        "FIXME",
        "TODO",
        "XXX",
        "@TODO", 
        "@todo"
    ]
}

I have a temporary fix adding - [ ] to my tags list

mhkeller commented 2 years ago

I dropped the default regular expression into regexpal.com with some sample text and it correctly highlighted the - [ ] line so I'm not sure why it's not getting highlighted in the doc or showing up in the tree.

VS Code info:

Version: 1.61.2 (Universal)
Commit: 6cba118ac49a1b88332f312a8f67186f7f3c1643
Date: 2021-10-19T15:49:28.381Z (2 wks ago)
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 19.6.0
Gruntfuggly commented 2 years ago

Yes, the default regex was updated in 0.0.214, so that it handles markdown in a more logical way. It expects [ ] and [x] to be added as tags. I had done this as a pop up option previously - now the default has changed I should have added the tags automatically. 🤦

Sorry about that - I will add them in the next release.

mhkeller commented 2 years ago

Thanks for looking into it!

Gruntfuggly commented 2 years ago

This should be fixed in the latest version