search

Gruntfuggly / todo-tree

Use ripgrep to find TODO tags and display the results in a tree view
Other
1.42k stars 137 forks source link

Add prettier to devDependencies to format code #634

Closed kjmatsuda closed 2 years ago

kjmatsuda commented 2 years ago

Hi! Thank you for sharing todo-tree. It's very useful! This project motivates me to contribute.

I propose this pull request. This is about code formatting. I think in this project, there is no formatter. If someone like me motivated to contribute, the absense of formatter can be barrier to do so. So here I am.

I wanted to make format file which go along with current code base. But there is no option to do it in prettier, and prettier wouldn't add option any more. Options · Prettier https://prettier.io/docs/en/options.html

Option Philosophy · Prettier https://prettier.io/docs/en/option-philosophy.html

I applied prettier formatting in src. I tested by "npm run test", and there is no fail.

Could you tell me about your thoughts on that?

If this is not acceptable to you, it's ok, I will try to adapt myself to the format of current code base.

kjmatsuda commented 2 years ago

Hi! I've been thinking, this is too much for first pull request. So I close this and look around for another improvements. Thank you,