Gruntfuggly / todo-tree

Use ripgrep to find TODO tags and display the results in a tree view
Other
1.4k stars 135 forks source link

TODOs may suddenly disappear when clicking in the list (macos arm64) #712

Closed yw662 closed 1 year ago

yw662 commented 1 year ago

I know it sounds funny but:

https://user-images.githubusercontent.com/34736747/209034257-bc47e62a-b996-4c1e-b1f2-6030e6d12d5b.mov

VSCode: 1.74.2 Electron: 19.1.8 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.1.0

macos: 13.0.1 TODO Tree: v0.0.220 - 2022-11-07

config:

  "todo-tree.general.enableFileWatcher": true,
  "todo-tree.highlights.highlightDelay": 0,
  "todo-tree.general.tags": [
    "BUG",
    "HACK",
    "TODO",
    "eslint"
  ],
  "todo-tree.general.showActivityBarBadge": true,
  "todo-tree.general.statusBar": "tags",
  "todo-tree.highlights.enabled": true,
  "todo-tree.general.showIconsInsteadOfTagsInStatusBar": true,
  "todo-tree.highlights.customHighlight": {
    "BUG": {
      "icon": "bug",
      "fontWeight": "bold",
      "foreground": "#ff0000"
    },
    "HACK": {
      "icon": "zap",
      "fontWeight": "bold",
      "foreground": "#ff7700"
    },
    "TODO": {
      "icon": "milestone",
      "fontWeight": "bold",
      "foreground": "#009900"
    },
    "eslint": {
      "fontWeight": "bold",
      "fontStyle": "italic",
      "textDecoration": "underline",
      "type": "text",
      "background": "#ffffff00",
      "iconColour": "#009900",
      "icon": "skip",
      "hideFromStatusBar": true,
      // "hideFromTree": true
    },
  },
  "todo-tree.tree.scanMode": "workspace only",
  "todo-tree.tree.disableCompactFolders": true,
  "todo-tree.tree.showCountsInTree": true,
  "todo-tree.tree.showBadges": false,
  "todo-tree.filtering.ignoreGitSubmodules": true
yw662 commented 1 year ago

I find this issue may not appear when scan mode is "workspace and open file".

yw662 commented 1 year ago

It happens when scan mode is "workspace only" and an opened file with some TODOs is closed. It seems the TODOs in the just closed file is removed from the list even in workspace only mode: are not added back because auto refreshing is no kicking in. However it cannot explain the whole behavior: I tried closing a file with 3 entries but 6 entries are removed from the list.

yw662 commented 1 year ago

Turning off autoRefresh solves the problem, but I believe this is not the behavior it should have when the scan mode is "workspace only".

yw662 commented 1 year ago

Maybe I should close this one and describe it in a new issue somehow.