search

Gruntfuggly / todo-tree

Use ripgrep to find TODO tags and display the results in a tree view
Other
1.4k stars 135 forks source link

Use woff file as icon for activity bar #751

Closed niccolomineo closed 1 year ago

niccolomineo commented 1 year ago

Fixes #737

Gruntfuggly commented 1 year ago

Hi - I merged this to try it out, but it changes the icon?

image

Was this what was expected?

Gruntfuggly commented 1 year ago

Looks like it's showing the 'noglyph' image?

Gruntfuggly commented 1 year ago

OK progress - managed to get it to show the tree icon, but it's about half size at the moment.

niccolomineo commented 1 year ago

That's weird, it should be exactly the same glyph I used for another extension, but with your logo. I'll have a look at the glyph and let you know.

Gruntfuggly commented 1 year ago

I've got it working - I resized it and changed the code and it now seems to work. Just about to publish a new version.

niccolomineo commented 1 year ago

I've got it working - I resized it and changed the code and it now seems to work. Just about to publish a new version.

Awesome. 🙂

Gruntfuggly commented 1 year ago

Could you do me a favour and install this version to see if it works correctly for you? todo-tree-0.0.227.vsix.zip

niccolomineo commented 1 year ago

Could you do me a favour and install this version to see if it works correctly for you? todo-tree-0.0.227.vsix.zip

Works just fine.

Gruntfuggly commented 1 year ago

Thanks - and thanks for the contribution 😄

niccolomineo commented 1 year ago

All good here? I saw you reverted the commit.

Gruntfuggly commented 1 year ago

I was already to go but for some reason I can no longer publish extension updates - I thought it was something to do with the icon but it seems to be unrelated. Just haven't had time to work out where the issue is yet.

Hopefully I'll get a chance this weekend.